From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.8235.1621760606784858793
 for <devel@edk2.groups.io>;
 Sun, 23 May 2021 02:03:26 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Opul9qam;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id EED0461151
	for <devel@edk2.groups.io>; Sun, 23 May 2021 09:03:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1621760606;
	bh=2StVquBJST17TscARgM119vQyDFzc2gdy03teOxpn18=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Opul9qamMc31nPDdDFSVU+dpyxfKL9mLRAXdoPX/xtlo8fgTqAhuhiHujTUCZfxxp
	 3PYzhXZJ2hlfUby62rZAZWDA3fwMqZLrkP4+POsi4ghYer7ZDBpyKBJTdKRd1hyRDj
	 HlmN0gbB2iockOq9YHGg9aDfD2YBKr2AG/07Whh5BYS0G3Q7pnxr+XQbBSrsdhZoi9
	 YpbEO6RMKb72EiLrS1NB4x24Zsa3rnZEUm58hJfqzuyv+/oW8AllxWfUANKxFIpawQ
	 Pksi+jEav5HStfL4XpZlNUGAK3bts1nGlAbHapzv9H62W+fvQtD13TdenhC0vY9FxZ
	 rk/D2aZ7rimYQ==
Received: by mail-ot1-f45.google.com with SMTP id 80-20020a9d08560000b0290333e9d2b247so11746887oty.7
        for <devel@edk2.groups.io>; Sun, 23 May 2021 02:03:25 -0700 (PDT)
X-Gm-Message-State: AOAM532vfpos5xHmN6z0s9qCxJwxWDOlU2Nj7HIHOyZl19CEQkS1KfvT
	BZxNvJMYwo/PrN4xmEb606yNBlwcAZUCHpdD2dc=
X-Google-Smtp-Source: ABdhPJwQkMijq51XVmUFuwUlGHIcOFG32K39q9apHvxsiRs54nwPoQ2nP+zEnaOpTctItloF0oJJ5M3RpAafJMzoGsk=
X-Received: by 2002:a05:6830:4da:: with SMTP id s26mr14090370otd.77.1621760605336;
 Sun, 23 May 2021 02:03:25 -0700 (PDT)
MIME-Version: 1.0
References: <20210309164510.19272-1-joey.gouly@arm.com> <DB8PR08MB5433B1BE74D3847F4CE1E44D94299@DB8PR08MB5433.eurprd08.prod.outlook.com>
 <15e1864b-1eb3-921b-3b10-2aba99afc9a0@redhat.com>
In-Reply-To: <15e1864b-1eb3-921b-3b10-2aba99afc9a0@redhat.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Sun, 23 May 2021 11:03:14 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGNtSwq9czVwptWGtaHcOUsofxi0JRA5NsPiZoiT5mjsQ@mail.gmail.com>
Message-ID: <CAMj1kXGNtSwq9czVwptWGtaHcOUsofxi0JRA5NsPiZoiT5mjsQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, joey.gouly@arm.com, 
	"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>, "leif@nuviainc.com" <leif@nuviainc.com>, 
	Sami Mujawar <Sami.Mujawar@arm.com>, Andreas Sandberg <Andreas.Sandberg@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, 23 May 2021 at 10:55, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 05/21/21 12:49, Joey Gouly wrote:
> >> From: Joey Gouly <joey.gouly@arm.com>
> >> Sent: 09 March 2021 16:45
> >> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
> >
> > Hi,
> >
> > A little ping on this. Can someone take a look?
> >
> > There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so I think it would be good get this in.
>
> This even looks like a candidate for edk2-stable202105 to me (it's small
> and arguably a clear-cut bugfix).
>
> NB the comment style should be:
>
>   //
>   // Interrupt ID 1020-1023 are reserved:
>   //
>
> IOW, we need a trailing and a leading empty comment line, plus the
> semicolon at the end of the comment should likely be a colon, or maybe
> just a period.
>

With that,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>