From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5B0B6AC1705 for ; Mon, 11 Sep 2023 13:14:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hJMy2fYG2yaiWOznJXwfN8VQnAG4SFCRBcun2aI73Ws=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1694438078; v=1; b=kmblht6s+T1kAR1PBs5qcrtK43yoYAX54j37wCb63nOlvLEI0bprUgF+FG0qbsa5nwbD3QFU RIgxPMWlC4isj61UV1z5fpHJyewJrgdkPNP9DmGVTgW+rIB8/cbjAAtv0RJhfLT9fqXUS5OsrGy qlbnU8FFyIzJJxEI2YmJyV88= X-Received: by 127.0.0.2 with SMTP id tt6aYY7687511xIlnLNPAvHY; Mon, 11 Sep 2023 06:14:38 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.58126.1694438078212744774 for ; Mon, 11 Sep 2023 06:14:38 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DD1E61190 for ; Mon, 11 Sep 2023 13:14:37 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60EA1C433CA for ; Mon, 11 Sep 2023 13:14:37 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2b974031aeaso75956821fa.0 for ; Mon, 11 Sep 2023 06:14:37 -0700 (PDT) X-Gm-Message-State: NrzVig6fFR4JbcvhpuDInepwx7686176AA= X-Google-Smtp-Source: AGHT+IH0PKAzr3FytWHkdzWI/bJdW6tWRTL/rDUJ5SkuiaOnPDckvuEVyTQRi7PklFfVx+6PsmTO62vw8uz6axQM7yI= X-Received: by 2002:a2e:b164:0:b0:2bb:94e4:49f with SMTP id a4-20020a2eb164000000b002bb94e4049fmr7488970ljm.32.1694438075510; Mon, 11 Sep 2023 06:14:35 -0700 (PDT) MIME-Version: 1.0 References: <20230907090212.485-1-linus.liu@intel.com> In-Reply-To: <20230907090212.485-1-linus.liu@intel.com> From: "Ard Biesheuvel" Date: Mon, 11 Sep 2023 15:14:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. To: devel@edk2.groups.io, linus.liu@intel.com Cc: Qi Zhang , Rahul Kumar , Jiewen Yao , Tina Chen , Xiao X Chen Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kmblht6s; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 7 Sept 2023 at 11:02, Linus Liu wrote: > > From: Linus Liu > > https://bugzilla.tianocore.org/show_bug.cgi?id=3004 > > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > Cc: Tina Chen > Cc: Xiao X Chen This patch is missing a signed-off-by line > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key > // this is only available if encryption is supported > // > - AvalDiskActions->SecureErase = 1; > + if (SupportedAttributes->MediaEncryption) { > + AvalDiskActions->SecureErase = 1; > + } else { > + AvalDiskActions->SecureErase = 0; > + } > } else { > AvalDiskActions->PsidRevert = 0; > AvalDiskActions->SecureErase = 0; > -- > 2.39.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368 > Mute This Topic: https://groups.io/mt/101210886/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108486): https://edk2.groups.io/g/devel/message/108486 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-