Re: [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 29 Mar 2023 at 12:49, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Ard,
>
> I am occassionally seeing the following error when trying to run the
> Kvmtool guest firmware.
>
>               add-symbol-file
> w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\PcRtc.dll
> 0xBBF80000
>               Loading driver at 0x000BBF70000 EntryPoint=0x000BBF82958
> PcRtc.efi
>               Failed to set memory attributes. Status = 00000002
>              Failed to map memory for motorola,mc146818. Status = 00000002
>
>              ASSERT_EFI_ERROR (Status = 00000002)
>              ASSERT [PcRtc]
> w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\AutoGen.c(494):
> !(((INTN)(RETURN_STATUS)(Status)) < 0)
>
> I am not sure why this issue only surfaces sometimes (which is
> worrying). However, the fix for this is patch 4/4 in this series.
>

I suppose the dispatch order is not fixed, which is surprising. But I
think the fix is quite appropriate in any case.

> Is it possible to review the ArmVirtPkg changes and if I have your
> approval to merge this series, please?
>

Feel free to go ahead and merge them

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>