From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.22503.1680090970305215120 for ; Wed, 29 Mar 2023 04:56:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T2lLpHLU; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D27D6B822E3 for ; Wed, 29 Mar 2023 11:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D839C4339B for ; Wed, 29 Mar 2023 11:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680090966; bh=RLRf8M4z1qgliFI9j3MnJQWSIapxKXeGHfu4jspFnQo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=T2lLpHLUx4k+NXndvEZFllQuKyRvz6UvWKIpX6v3EYFlLQ3/H6kv9WkLhjJlSdo21 Tt7w7PGuqAmKlefKz+myj3GVYYf7PqQusaJ/giLudHcGwHWDv7TOIcfaMMI8201rH4 ZT/WlB8DuI+Krok9Fllvblnpo9JUGxhd0Fzm2Ya7PzzfY+IzHHNjq3OK3gMkYWGYE1 GFT7u4Ww2h+U5JfoWJQmOYMn3GqXHjGU7lV/uURy9m4eN5xwH8Gi2IyFZeXMRbFvjs LaSG/4jRzuhRR9/eDCWUBooQbxN/fz3y97+8NNi61kyuZeX8wKUNrrXN6MtuspV6hs 05XZMQXY/w43Q== Received: by mail-lf1-f51.google.com with SMTP id q16so19763181lfe.10 for ; Wed, 29 Mar 2023 04:56:06 -0700 (PDT) X-Gm-Message-State: AAQBX9fOVEUqnw3DM70RonGxpUF5RmtRwKoCFMoOv6Deqa7eWt3FOHAn 5V8tfmxHNBm3JKiydjOJ3HOXFx5P/zce2nYKfo8= X-Google-Smtp-Source: AKy350bUzRYdBR9oGCREG0S5iSv0typ8NoxbBKDFABrntVLE06cVjOT9OZGM2JwZSCROXJYLLR+gpeTyW0gMRLhfgZA= X-Received: by 2002:ac2:46e4:0:b0:4e9:8c46:32ad with SMTP id q4-20020ac246e4000000b004e98c4632admr5498707lfo.9.1680090964592; Wed, 29 Mar 2023 04:56:04 -0700 (PDT) MIME-Version: 1.0 References: <20230320140557.40348-1-sami.mujawar@arm.com> <06319e3d-9b2b-c92d-7d32-8c569b179b76@arm.com> In-Reply-To: <06319e3d-9b2b-c92d-7d32-8c569b179b76@arm.com> From: "Ard Biesheuvel" Date: Wed, 29 Mar 2023 13:55:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool To: Sami Mujawar Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, kraxel@redhat.com, pierre.gondois@arm.com, Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com Content-Type: text/plain; charset="UTF-8" On Wed, 29 Mar 2023 at 12:49, Sami Mujawar wrote: > > Hi Ard, > > I am occassionally seeing the following error when trying to run the > Kvmtool guest firmware. > > add-symbol-file > w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\PcRtc.dll > 0xBBF80000 > Loading driver at 0x000BBF70000 EntryPoint=0x000BBF82958 > PcRtc.efi > Failed to set memory attributes. Status = 00000002 > Failed to map memory for motorola,mc146818. Status = 00000002 > > ASSERT_EFI_ERROR (Status = 00000002) > ASSERT [PcRtc] > w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\AutoGen.c(494): > !(((INTN)(RETURN_STATUS)(Status)) < 0) > > I am not sure why this issue only surfaces sometimes (which is > worrying). However, the fix for this is patch 4/4 in this series. > I suppose the dispatch order is not fixed, which is surprising. But I think the fix is quite appropriate in any case. > Is it possible to review the ArmVirtPkg changes and if I have your > approval to merge this series, please? > Feel free to go ahead and merge them Reviewed-by: Ard Biesheuvel