[PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description

[PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description

[Masahisa Kojima]

Since ACPI is well supported on SynQuacer platform, set ACPI as
default hardware description.

Only changing the "DEFAULT" flags from ACPIPREF_DT to ACPIPREF_ACPI
does not work as expected, this commit also replaces the value
of ACPIPREF_DT and ACPIPREF_ACPI.

Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
---
 Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h            | 4 ++--
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
index 6ac63e64ecbd..271a340e74b4 100644
--- a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
+++ b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
@@ -16,8 +16,8 @@
 #define PCIE_MAX_SPEED_UNLIMITED          0x0
 #define PCIE_MAX_SPEED_GEN1               0x1
 
-#define ACPIPREF_DT                       0x0
-#define ACPIPREF_ACPI                     0x1
+#define ACPIPREF_ACPI                     0x0
+#define ACPIPREF_DT                       0x1
 
 typedef struct {
   UINT8         EnableEmmc;
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
index 6707687b279a..6e6c89c3eccd 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
@@ -61,8 +61,8 @@ formset
         prompt      = STRING_TOKEN(STR_DT_ACPI_SELECT_PROMPT),
         help        = STRING_TOKEN(STR_DT_ACPI_SELECT_HELP),
         flags       = NUMERIC_SIZE_1 | INTERACTIVE | RESET_REQUIRED,
-        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = DEFAULT;
-        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = 0;
+        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = DEFAULT;
+        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = 0;
     endoneof;
 
     subtitle text = STRING_TOKEN(STR_NULL_STRING);
-- 
2.17.1

Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description

[Ard Biesheuvel]

On Fri, 19 Aug 2022 at 09:00, Masahisa Kojima
<masahisa.kojima@linaro.org> wrote:
>
> Since ACPI is well supported on SynQuacer platform, set ACPI as
> default hardware description.
>
> Only changing the "DEFAULT" flags from ACPIPREF_DT to ACPIPREF_ACPI
> does not work as expected, this commit also replaces the value
> of ACPIPREF_DT and ACPIPREF_ACPI.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 1096b98314e6..46686eeb7e78

Thanks!

> ---
>  Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h            | 4 ++--
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
> index 6ac63e64ecbd..271a340e74b4 100644
> --- a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
> +++ b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h
> @@ -16,8 +16,8 @@
>  #define PCIE_MAX_SPEED_UNLIMITED          0x0
>  #define PCIE_MAX_SPEED_GEN1               0x1
>
> -#define ACPIPREF_DT                       0x0
> -#define ACPIPREF_ACPI                     0x1
> +#define ACPIPREF_ACPI                     0x0
> +#define ACPIPREF_DT                       0x1
>
>  typedef struct {
>    UINT8         EnableEmmc;
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> index 6707687b279a..6e6c89c3eccd 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> @@ -61,8 +61,8 @@ formset
>          prompt      = STRING_TOKEN(STR_DT_ACPI_SELECT_PROMPT),
>          help        = STRING_TOKEN(STR_DT_ACPI_SELECT_HELP),
>          flags       = NUMERIC_SIZE_1 | INTERACTIVE | RESET_REQUIRED,
> -        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = DEFAULT;
> -        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = 0;
> +        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = DEFAULT;
> +        option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = 0;
>      endoneof;
>
>      subtitle text = STRING_TOKEN(STR_NULL_STRING);
> --
> 2.17.1
>