From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web09.706.1660896698916762358 for ; Fri, 19 Aug 2022 01:11:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WB19nltc; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EF75AB82669 for ; Fri, 19 Aug 2022 08:11:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 939F8C433C1 for ; Fri, 19 Aug 2022 08:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660896695; bh=cs9kGfSY46S3FDvb8LdxYEFRuI8BDZFfJtbH7bR0P9o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WB19nltcnyqXUfI+kw8e+GxGXOA+w17MpFqwFq6lHisFXVFWh8GYasqqku7Jmxivj Q4IXtu4KyaecTD/C6DsOlm1A5EPTrPVPOJJuWm70/0xxTy59vt/qfb/g28p7aXZfiO EUWN6UaFRzvb4S9nC7jDUh6vGsd+ckQ9JyYWE1F1FYkbonOXUt1m0x4QCd9Rdeetum P8pAn3ERUgzhn4eMGBseZdqTHzlmZOMgF1CmxyJt8qiYz58r2CDordkdUv203v4EjR hLO37fakFFes1GA6fvYdhHvqpCUjBX6df+YA4OmCGA2q8kF0xl3Z79bHsMMnkWvXS3 BfMIMxsH7eo4Q== Received: by mail-wm1-f46.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso2115369wmb.2 for ; Fri, 19 Aug 2022 01:11:35 -0700 (PDT) X-Gm-Message-State: ACgBeo0x5HrBdw0LBQdn0Eoi6pRSQ7X+lG10TsTWmaQu+Vtiwx2HiAsl IWkHaBrdE/KsLafsjT9AiZ0zGkdBmZ7c41bi1Hk= X-Google-Smtp-Source: AA6agR6BLIZSklKJM2F7KbjpxgGI9H8/lrGEhwjlfgUzK2o+JTnrlBuPTEe7u9ViklkC7Q8fI2PrsTXvoTWoIXp2MXo= X-Received: by 2002:a05:600c:3586:b0:3a5:fb24:a205 with SMTP id p6-20020a05600c358600b003a5fb24a205mr7358241wmq.77.1660896693882; Fri, 19 Aug 2022 01:11:33 -0700 (PDT) MIME-Version: 1.0 References: <20220819070014.17247-1-masahisa.kojima@linaro.org> In-Reply-To: <20220819070014.17247-1-masahisa.kojima@linaro.org> From: "Ard Biesheuvel" Date: Fri, 19 Aug 2022 10:11:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description To: Masahisa Kojima Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm , Jassi Brar Content-Type: text/plain; charset="UTF-8" On Fri, 19 Aug 2022 at 09:00, Masahisa Kojima wrote: > > Since ACPI is well supported on SynQuacer platform, set ACPI as > default hardware description. > > Only changing the "DEFAULT" flags from ACPIPREF_DT to ACPIPREF_ACPI > does not work as expected, this commit also replaces the value > of ACPIPREF_DT and ACPIPREF_ACPI. > > Signed-off-by: Masahisa Kojima Reviewed-by: Ard Biesheuvel Pushed as 1096b98314e6..46686eeb7e78 Thanks! > --- > Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h | 4 ++-- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h > index 6ac63e64ecbd..271a340e74b4 100644 > --- a/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h > +++ b/Silicon/Socionext/SynQuacer/Include/Platform/VarStore.h > @@ -16,8 +16,8 @@ > #define PCIE_MAX_SPEED_UNLIMITED 0x0 > #define PCIE_MAX_SPEED_GEN1 0x1 > > -#define ACPIPREF_DT 0x0 > -#define ACPIPREF_ACPI 0x1 > +#define ACPIPREF_ACPI 0x0 > +#define ACPIPREF_DT 0x1 > > typedef struct { > UINT8 EnableEmmc; > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > index 6707687b279a..6e6c89c3eccd 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > @@ -61,8 +61,8 @@ formset > prompt = STRING_TOKEN(STR_DT_ACPI_SELECT_PROMPT), > help = STRING_TOKEN(STR_DT_ACPI_SELECT_HELP), > flags = NUMERIC_SIZE_1 | INTERACTIVE | RESET_REQUIRED, > - option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = DEFAULT; > - option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = 0; > + option text = STRING_TOKEN(STR_DT_ACPI_SELECT_ACPI), value = ACPIPREF_ACPI, flags = DEFAULT; > + option text = STRING_TOKEN(STR_DT_ACPI_SELECT_DT), value = ACPIPREF_DT, flags = 0; > endoneof; > > subtitle text = STRING_TOKEN(STR_NULL_STRING); > -- > 2.17.1 >