From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.1245.1628606481008189882 for ; Tue, 10 Aug 2021 07:41:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D1/+iGvv; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 83A8160F41 for ; Tue, 10 Aug 2021 14:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628606480; bh=3ZYqr3ze/+1cK8k1/H4bRfk8dQrIkSgAVTi5MK89J0M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=D1/+iGvv5JVRLvPZqbbLGd4lHPPEKjN896H0GWiudGQ+CnitauzRjDCuqz8v5WsC0 jHcRgxw0vXfBqw8/q8lbeinVIgQor5b4kH2ersoZUPtdSvwUnGNZDKvBXwiH6C1Pug Elw0aygHusHfix+xEOmvs96F+abdng7duajNFHgTYelCEoNUxvXgIvxl4if5nzr/Yn VcVf13bL0RQMJ4idsid3c63Gd986UA8JHbK66rm9s5Og0AyE+189fO5lkC/N6DxLLW AzOYF6t+ergZprZjkEUwwRwddLmKzDrMPHCtfSomVcXzqSaxuBedWUHnVtVBKnh+Fr 3pgAliv3seR3Q== Received: by mail-oi1-f175.google.com with SMTP id u25so29117084oiv.5 for ; Tue, 10 Aug 2021 07:41:20 -0700 (PDT) X-Gm-Message-State: AOAM5328i/rutz0dm1xirWolCH9RJhfy4uV0Fv1FjcsJ/h9nL36sLdJp 6iSY+xwWpRN9T5PpJz+JXpuCtfL9CEsfdOeq/FA= X-Google-Smtp-Source: ABdhPJzagriH7pCENaIWYWxfeu8zlKgFJaD5tjM81Mo3CEieIGDKp70MbGLnFO5SW6tu3eShVGG0a1gZKRnJqqQITq0= X-Received: by 2002:aca:dd89:: with SMTP id u131mr3847599oig.47.1628606479854; Tue, 10 Aug 2021 07:41:19 -0700 (PDT) MIME-Version: 1.0 References: <20210719093015.1490932-1-mw@semihalf.com> <20210719093015.1490932-3-mw@semihalf.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 10 Aug 2021 16:41:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables To: edk2-devel-groups-io , Samer El-Haj-Mahmoud Cc: Marcin Wojtas , Leif Lindholm , Ard Biesheuvel , Grzegorz Jaszczyk , Grzegorz Bernacki , "upstream@semihalf.com" , "Jon (jon@solid-run.com)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 10 Aug 2021 at 16:36, Samer El-Haj-Mahmoud wrote: > > Apologies for the tardiness in replying to this. Please see my comments b= elow. > > > -----Original Message----- > > From: Marcin Wojtas > > Sent: Friday, July 30, 2021 5:57 AM > > To: Ard Biesheuvel > > Cc: Samer El-Haj-Mahmoud ; edk2- > > devel-groups-io ; Leif Lindholm > > ; Ard Biesheuvel ; > > Grzegorz Jaszczyk ; Grzegorz Bernacki > > ; upstream@semihalf.com; Jon (jon@solid-run.com) > > > > Subject: Re: [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: > > Add missing _STA methods in ACPI tables > > > > Hi Ard, > > > > czw., 29 lip 2021 o 11:58 Ard Biesheuvel napisa=C5=82= (a): > > > > > > On Thu, 29 Jul 2021 at 11:46, Marcin Wojtas wrote: > > > > > > > > Hi Ard, > > > > > > > > pon., 19 lip 2021 o 17:06 Marcin Wojtas napisa=C5= =82(a): > > > > > > > > > > Hi Ard, > > > > > > > > > > pon., 19 lip 2021 o 11:54 Ard Biesheuvel napisa= =C5=82(a): > > > > > > > > > > > > On Mon, 19 Jul 2021 at 11:31, Marcin Wojtas > > wrote: > > > > > > > > > > > > > > BBR 1.0 spec says that _STA is required for each device in DS= DT or > > SSDT. > > > > > > > Fix that for all platforms with the Marvell SoC's. > > > > > > > > > > > > > > > > > > > Can we fix the BBR instead? If ACPI itself does not require _ST= A, BBR > > > > > > should not require it either. > > > > > > > > > > > > > > > > > > > > > > I consulted with ARM on the matter. SBBR has requirements of thin= gs > > > > > that are otherwise optional in UEFI/ACPI/SMBIOS. Also some OS's m= ay > > > > > require that and I can see those methods in most of the other ACP= I > > > > > source files in the edk2-platfoms tree. I think the BBR requireme= nts > > > > > discussions can follow, but it would be great if this change can = be > > > > > applied, so that no to block other development. > > > > > > > > > > > > > Do you have any feedback to the patchset and the _STA methods > > concerns? > > > > > > > > > > Yes. I would like to understand why _STA methods are now mandated by > > BBR. > > > > > > > Understood. Providing an answer may not be immediate and may possibly > > require further discussion on the SystemArchAC level. > > How about we withdraw this single patch for now and process the > > remaining ones? We would come back to the _STA subject, as soon as > > there's more information available. > > > > Best regards, > > Marcin > > > > _STA has been required in SBBR since ver 1.0 (published 2016, with the 0.= 9 draft since 2014) > https://developer.arm.com/documentation/den0044/b/?lang=3Den > > I do not have the history on why SBBR 1.0+ requires _STA, but it most lik= ely has to do wit the Windows strong use case for it: https://docs.microsof= t.com/en-us/windows-hardware/drivers/bringup/device-management-namespace-ob= jects#device-status-changes . Windows is a key OS targeted by SBBR. > OK, I stand corrected again :-) Marcin, I won't object further to these additions -please respin the patch on top of current edk2-platform and I will apply it right away.