From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.808.1685461527254231398 for ; Tue, 30 May 2023 08:45:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P9d5gaX2; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3D4860A36 for ; Tue, 30 May 2023 15:45:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A298CC433A1 for ; Tue, 30 May 2023 15:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685461525; bh=jJM4SqQc5hwKOtbroCDNevVr384tmKz84iet0KX1c+w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=P9d5gaX2hLT3+trUdn006Z3xcjDCU1ThkFO44nwXnla729jQtvveP00ajiprewEQA X0ssgFQjdB2NlVwrXSYrBy0nJyP0IqDeKQmWxwFj2yvElcpCP4PdIOku4U0bzPV2bA W8hyfMNKHkNxZCDTS+esS524FkbGAmCNa60WZNjk8B8h5YPZ28gxJM0spzlyjC5JWb E5GggcfIzrJ7sbUGn6qY0OsjBrwaD0TL5GVYkRyq/OsgNmAQQApPUEh3Dh/HHMUYpF 5jf2I5QEzOr+2ivHrQUOPOpec1nUjnDecjfio3Z+70tZXArfiZKn4LDw+AStrvTilA sKemUo3DtOq7g== Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f5021faa16so2633186e87.2 for ; Tue, 30 May 2023 08:45:25 -0700 (PDT) X-Gm-Message-State: AC+VfDzthvJ4kSGx3zZHF0rNxALC3LYapspMvUWwJk1l+WnxdIf/xlw8 s/WUlzRgMXgml+SguhsBCNm/DSe3guBxX4FFcec= X-Google-Smtp-Source: ACHHUZ4dlSmilC8q7y4FEpBHItU2KYvO/NT8/cGVkJEhAjb4MoEEyUttVg0fSM8pqgDzrZu95AN5epNUkmN8Mx/Sg0g= X-Received: by 2002:a2e:8283:0:b0:2ac:598e:e946 with SMTP id y3-20020a2e8283000000b002ac598ee946mr1152535ljg.3.1685461523650; Tue, 30 May 2023 08:45:23 -0700 (PDT) MIME-Version: 1.0 References: <4bcb9012-7e12-9df0-59a4-aff46b911c8f@bsdio.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 30 May 2023 17:45:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] failed Pr To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , Sean Brogan , Rebecca Cran , "Kubacki, Michael" , "Gao, Liming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 30 May 2023 at 17:36, Kinney, Michael D wrote: > > After looking at GitHub Action features the best approach is likely > a PR comment that provides a request to rerun all failed jobs. > > We can define a comment format to indicate a command to a tianocore bot. > Sounds reasonable, although doesn't that imply that anyone who can comment can trigger this action? > > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Tuesday, May 30, 2023 7:36 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Sean Brogan ; Rebecca Cran ; > > Kubacki, Michael ; Gao, Liming > > > > Subject: Re: [edk2-devel] failed Pr > > > > On Mon, 29 May 2023 at 18:45, Michael D Kinney > > wrote: > > > > > > Hi Sean, > > > > > > > > > > > > I see the =E2=80=9Crerun=E2=80=9D button on the =E2=80=9Cchecks=E2=80= =9D page of GitHub from my login. > > > > > > > > > > > > We have a mix of both Azure Pipelines and GitHub Actions today, so I > > think it is important to see the =E2=80=9Crerun=E2=80=9D from GitHub vi= ew for Maintainers. > > > > > > > Yes, that would be lovely. > > > > > > > > > > > This github page describes the feature, but not the permissions requi= red. > > > > > > > > > > > > https://docs.github.com/en/actions/managing-workflow-runs/re-running- > > workflows-and-jobs > > > > > > > > > > > > We currently have EDK II Maintainer Team set to =E2=80=9CTriage Role= =E2=80=9D > > permissions. From the table below, only =E2=80=9CWrite=E2=80=9D and ab= ove are allowed to > > re-run. > > > > > > > > > > > > https://docs.github.com/en/organizations/managing-user-access-to-your= - > > organizations-repositories/repository-roles-for-an- > > organization#permissions-for-each-role > > > > > > > > > > > > =E2=80=9CWrite=E2=80=9D permissions add a lot of options, so I think = we should discuss > > tradeoffs in the next Tools/CI meeting. > > > > > > > > > > > > One option is to add a bot based on a new label to request failed job= s to > > be re-run. The bot can use a token with permissions to re-run. > > > > > > > This would work for me - as long as I don't have to make changes to > > the branch, I'm happy with whatever we come up with.