From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.44188.1676990394538572674 for ; Tue, 21 Feb 2023 06:39:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MlMd+YVl; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F0B261018 for ; Tue, 21 Feb 2023 14:39:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1654C4339B for ; Tue, 21 Feb 2023 14:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676990391; bh=U+eDiqcYGPqS+D6x/nr1T32s3tdoM7t0lKzgnzyFdNU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MlMd+YVlZwtAb9CwTRmgS1nlmhELtET+fzZLAgcaajkyp8zFjC+fHjZjsEcOqDh7V LdaTMjzETygcyv4dfO/wb9JvJ472c6KWt8BN3BuF0ZwF3ZdGmVW3x4QIn9V//ntivG A/OCj0nTInBRFnGYmMtVDMmxDG4MDg0lXjL5pdpx2fE9HcfE5QazCIHZTi/ezaUxIa V1ZKCJUQVa6qsKJwwr4ybxJ813Y6/jf+ggiGk0P/HMBjKxB7zSwLEgU+XWTAVoAIaL hE/wyEpVoPDhxURtbdtbti/8kw5XzvlqNGAryZ3Azo1rX62bCx9pqqkY5bxeF22yzp HSByd9bLUuN9g== Received: by mail-lj1-f172.google.com with SMTP id z5so4613042ljc.8 for ; Tue, 21 Feb 2023 06:39:51 -0800 (PST) X-Gm-Message-State: AO0yUKVuL0ZlPhpY1JZQf9fwyg++Zosw8Fn9RzT1yB978UokRjVH9gRj Y31jPD9+gWerhaMz0c5xFWuQ2US6RZ1GEhruBrE= X-Google-Smtp-Source: AK7set+jdWP0gNyvRHOdhss50l/y9ta7qoDE94hb0ocoDEinaEGx/Dv9cy58OAZbWSqn/QpgQyvRJMhwSPQti1P7oI8= X-Received: by 2002:a2e:a4cc:0:b0:295:8ef2:8707 with SMTP id p12-20020a2ea4cc000000b002958ef28707mr551699ljm.2.1676990389822; Tue, 21 Feb 2023 06:39:49 -0800 (PST) MIME-Version: 1.0 References: <20221201214935.67205-1-rebecca@quicinc.com> <32038087-00af-8b73-57c3-0778d59b417c@quicinc.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 21 Feb 2023 15:39:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Rebecca Cran , "Ni, Ray" Content-Type: text/plain; charset="UTF-8" On Tue, 21 Feb 2023 at 14:58, Gao, Zhichao wrote: > > Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create the PR after edk2 202302 release. > The hard freeze has been deferred until early march, so you can go ahead and merge this patch. -- Ard. > > -----Original Message----- > > From: Rebecca Cran > > Sent: Tuesday, February 21, 2023 8:45 AM > > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > > > > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > adding equals sign after time > > > > Could someone commit this please? > > > > On 12/5/22 19:17, Gao, Zhichao wrote: > > > Reviewed-by: Zhichao Gao > > > > > > Thanks, > > > Zhichao > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io On Behalf Of > > >> Rebecca Cran > > >> Sent: Friday, December 2, 2022 5:50 AM > > >> To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > >> > > >> Cc: Rebecca Cran > > >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > >> adding equals sign after time > > >> > > >> The output of the "ping" command shows the time without a space > > >> between the label and the value. e.g.: > > >> > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms > > >> > > >> Improve the readability and consistency by adding an equals sign for > > >> the time > > >> value: > > >> > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms > > >> > > >> Signed-off-by: Rebecca Cran > > >> --- > > >> > > >> > > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > >> andsLib.uni | 2 +- > > >> > > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > > >> andsLib.uni | 2 +- > > >> 2 files changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git > > >> > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> index 73cf96d9e614..37fd4a11929c 100644 > > >> --- > > >> > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> +++ > > >> > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> +++ mandsLib.uni > > >> @@ -52,7 +52,7 @@ > > >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no > > >> route to the destination '%B%s%N' from the source '%B%s%N' was > > >> found.\r\n" > > >> #string STR_PING_START #language en-US "Ping %s %d data > > >> bytes.\r\n" > > >> #string STR_PING_TIMEOUT #language en-US "Echo request > > >> sequence %d timeout.\r\n" > > >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > > >> icmp_seq=%d ttl=%d time%d~%dms\r\n" > > >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes > > from %s : > > >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > >> #string STR_PING_STAT #language en-US "\n%d packets > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > >> > > >> diff --git > > >> > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> index 30913ae5b583..cb9d39a33fbe 100644 > > >> --- > > >> > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> +++ > > >> > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> +++ mandsLib.uni > > >> @@ -33,7 +33,7 @@ > > >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > > >> sources in %s's multicast domain.\r\n" > > >> #string STR_PING6_START #language en-US "Ping %s %d data > > >> bytes\r\n" > > >> #string STR_PING6_TIMEOUT #language en-US "Echo request > > >> sequence %d timeout.\r\n" > > >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" > > >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > >> #string STR_PING6_STAT #language en-US "\n%d packets > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > >> #string STR_PING6_RTT #language en-US "\nRtt(round trip > > time) > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > >> > > >> -- > > >> 2.30.2 > > >> > > >> > > >> > > >> > > >> > > > > > > > >