From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.186.1616091282835906358 for ; Thu, 18 Mar 2021 11:14:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XRwgAiYk; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id EE1FA64F24 for ; Thu, 18 Mar 2021 18:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616091282; bh=O0rnfJ8yyqj6g3Vgsluc4UTC0YEpW/K/mxR+kSKcTKM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XRwgAiYkTuAjfjn7KkFcAg3sghXz+SK7br69gbkVzqOM8TC/fWAURWGFazPmRraXv 4jMvAwPkpBLvTQhaOQS+VWaFCoWE5E8PU170YHNhjO8lJ0EaxxNBUrWjQ9EerggjZd 0+kpMRemHT0E6Qo069/x9LUa7/nJ20ef8JPFbJ/2PZ2HfYTQo5Xhlr+eb7+LpCxnlp Obby3YzH057c0iLIc0htXQrvWPt9RIJqw6hhgFGtfdj6UA4L/JBinwaTVIZsPetkfg Ow+W1755G+1QjqbcuX/TEQPo3+42mFM5Fum3jwE7UmOlJKK//okXahz8QnovhyPm0C yt7pwkL/RmQQA== Received: by mail-oi1-f173.google.com with SMTP id a8so1903962oic.11 for ; Thu, 18 Mar 2021 11:14:41 -0700 (PDT) X-Gm-Message-State: AOAM531hLIDAusUGAct2jw7ebfaIbMbLzPAOkjy2dyW8fOrq3z77oRpF SsTAUCZb/M4m02GTgg2y4SsKrPYRNCAtqyBkLGs= X-Google-Smtp-Source: ABdhPJwodXSZnyeLr1InHY4dDOg057a9kvsKhvdutwTatp4SMxyUrkpsC1llHv1+g21yua3judec0gjvQXHuTmR8KU0= X-Received: by 2002:aca:1a01:: with SMTP id a1mr4003055oia.33.1616091281238; Thu, 18 Mar 2021 11:14:41 -0700 (PDT) MIME-Version: 1.0 References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5173C17A517.7039@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 18 Mar 2021 19:14:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe To: Kun Qin Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Thu, 18 Mar 2021 at 19:07, Kun Qin wrote: > > Hi Ard/Leif, > > Could you please review the change and let me know if you have any > feedback when there is chance? I can drop the patch if this package is > not supported/maintained any more. Please let me know how you would like > to proceed. > > Thanks in advance. > > Regards, > Kun > > On 03/16/2021 11:10, Kun Qin via groups.io wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > > > This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to > > resolve new dependency by VariableSmmRuntimeDxe. The library interface > > is consumed by variable module to better support variable runtime cache > > feature. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > > > Signed-off-by: Kun Qin Acked-by: Ard Biesheuvel > > --- > > > > Notes: > > v2: > > - No review, no change. > > > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > index 0a11b796cca5..acaa4cd90fc5 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > @@ -49,6 +49,8 @@ [LibraryClasses] > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > > !endif > > > > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > + > > [LibraryClasses.common.SEC] > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > >