From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.7079.1651059400655315868 for ; Wed, 27 Apr 2022 04:36:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KBpLxZ0U; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4C42B82661 for ; Wed, 27 Apr 2022 11:36:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BB54C385A9 for ; Wed, 27 Apr 2022 11:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651059397; bh=B3Si0NZyAk66NBJRybrbGrHY26yAsZmqGyCQNTNkKkA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KBpLxZ0UHEA/Rd9cOHtbVb/FoONjKVCFJtScbxuV2051zo6JlJJSJ9FZUQKrTH3I4 /CBccbrgvae3C0BkJeqeEWlbbhWFN69IFWtOfcA7LG3oHIAO+PqDo+4E8S9V5Pz6Iz JfZbkIxsdjksAMINAvyyhCyiVmXxfOLMaKWaDK2NzP1KIYyJBur3dv6btlsPDYjnkE ecvMCbUrDVu0FTpa2tStHwDngOD+lIz3p8w8IQ+lIubD1SNzngy0IT0rq0oCidcoRk 1kgCf36Cko/WGNnb0bYBo1RXjLxARhA7IHLTQW2mEFsGfXaINOuaRtydATJt/z/x4D n7nOyOf1hxuMA== Received: by mail-ot1-f48.google.com with SMTP id r14-20020a9d750e000000b00605446d683eso862480otk.10 for ; Wed, 27 Apr 2022 04:36:37 -0700 (PDT) X-Gm-Message-State: AOAM532c5nfSWtOxhDsWu1NWdsc+lhp/nQRVJq705lHPmSuyCNqpUstC MpljBK4f4UG47A6esRcrrsJc8W0cox46eJp4dq8= X-Google-Smtp-Source: ABdhPJz/cX7xOUaGtrdLluKPtOGg2xIWXeTnydNWPniQyr5KDYS5iWxubiY8XBfYsOrLGF47qHUpyfNa+ktMvI2a0VU= X-Received: by 2002:a05:6830:33eb:b0:5f8:d36d:3831 with SMTP id i11-20020a05683033eb00b005f8d36d3831mr9745043otu.265.1651059396535; Wed, 27 Apr 2022 04:36:36 -0700 (PDT) MIME-Version: 1.0 References: <20220427085935.17236-1-edward.pickup@arm.com> In-Reply-To: <20220427085935.17236-1-edward.pickup@arm.com> From: "Ard Biesheuvel" Date: Wed, 27 Apr 2022 13:36:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC To: Edward Pickup Cc: edk2-devel-groups-io , Sami Mujawar , Ard Biesheuvel , Thomas Abraham , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Edward, Thanks for the patch. On Wed, 27 Apr 2022 at 10:59, Edward Pickup wrote: > > When booting Linux on FVP RevC, Linux reports the following error: > > ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit > > This issue is due to the RC Address Limit not being configured in the > configuration manager for the platform. > > The default model parameter is configured to 32, so set this in the > configuration manager, fixing the error. > Why is 32 a suitable value? I would not expect emulated IP to have such a limitation. > Signed-off-by: Edward Pickup > --- > > The changes can be seen at https://github.com/edpickup/edk2-platforms/tre= e/1700_fix_IORT_RC_Addr_Limit_v1 > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Co= nfigurationManager.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationM= anagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationMa= nager/ConfigurationManagerDxe/ConfigurationManager.c > index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6d= eab2eb82fced9e2 100644 > --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD= xe/ConfigurationManager.c > +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD= xe/ConfigurationManager.c > @@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepository= Info =3D { > // ATS attributes > EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED, > // PCI segment number > - 0 > + 0, > + // Memory Address Size Limit > + 32 > }, > > // Array of Device ID mappings > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.