public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Pierre <Pierre.Gondois@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 0/6] Add ACPI support for Kvmtool
Date: Wed, 12 Jan 2022 11:51:39 +0100	[thread overview]
Message-ID: <CAMj1kXGTx7VNmh_d7Svndooxz8DNCN=3+fLin4koXGchnau_1A@mail.gmail.com> (raw)
In-Reply-To: <20220111161611.957688-1-Pierre.Gondois@arm.com>

On Tue, 11 Jan 2022 at 17:16, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3742
> V1: https://edk2.groups.io/g/devel/message/76990
> V2:
> - New patch: "DynamicTablesPkg: Print specifier macro for
>   CM_OBJECT_ID" [Laszlo]
> - Only add AcpiView for ArmVirtKvmTool instead of all ArmVirt
>   platforms. This is done using a 'ACPIVIEW_ENABLE' switch.
>   [Laszlo]
> - Only generate ACPI tables for AARCH64. [Laszlo]
> - Various modifications (error handling, patch organization,
>   coding style, etc). [Laszlo]
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1456_Add_ACPI_support_for_Kvmtool_v2
>
> Kvmtool dynamically generates a device tree describing the platform
> to boot on. Using the patch-sets listed below, the DynamicTables
> framework generates ACPI tables describing a similar platform.
>
> This patch-set:
>  - adds a ConfigurationManager and make use of the DynamicTablesPkg
>    in for Kvmtool for AARCH64, allowing to generate ACPI tables
>  - adds the acpiview command line utility to the ArmVirtPkg
>    platform that request if via the ACPIVIEW_ENABLE macro
>  - update ArmVirtPkg.ci.yaml to add new words and use the
>    DynamicTablesPkg
>  - adds a print specifier macro for the CM_OBJECT_ID type
>
> With this patchset, KvmTool on AARCH64 will use ACPI tables instead
> of a Device Tree (cf PcdForceNoAcpi Pcd).
>

How did you test this? Can we boot Linux in ACPI mode with these changes?


> Pierre Gondois (2):
>   DynamicTablesPkg: Print specifier macro for CM_OBJECT_ID
>   ArmVirtPkg: Add cspell exceptions
>
> Sami Mujawar (4):
>   ArmVirtPkg/Kvmtool: Add DSDT ACPI table
>   ArmVirtPkg/Kvmtool: Add Configuration Manager
>   ArmVirtPkg/Kvmtool: Enable ACPI support
>   ArmVirtPkg/Kvmtool: Enable Acpiview
>
>  ArmVirtPkg/ArmVirt.dsc.inc                    |    5 +-
>  ArmVirtPkg/ArmVirtKvmTool.dsc                 |   22 +-
>  ArmVirtPkg/ArmVirtKvmTool.fdf                 |   15 +-
>  ArmVirtPkg/ArmVirtPkg.ci.yaml                 |    6 +-
>  .../KvmtoolCfgMgrDxe/AslTables/Dsdt.asl       |   21 +
>  .../KvmtoolCfgMgrDxe/ConfigurationManager.c   | 1061 +++++++++++++++++
>  .../KvmtoolCfgMgrDxe/ConfigurationManager.h   |  120 ++
>  .../ConfigurationManagerDxe.inf               |   54 +
>  .../Include/ConfigurationManagerObject.h      |    7 +-
>  9 files changed, 1303 insertions(+), 8 deletions(-)
>  create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
>  create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.c
>  create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.h
>  create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf
>
> --
> 2.25.1

  parent reply	other threads:[~2022-01-12 10:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 16:16 [PATCH v2 0/6] Add ACPI support for Kvmtool PierreGondois
2022-01-11 16:16 ` [PATCH v2 1/6] DynamicTablesPkg: Print specifier macro for CM_OBJECT_ID PierreGondois
2022-01-11 16:16 ` [PATCH v2 2/6] ArmVirtPkg: Add cspell exceptions PierreGondois
2022-01-11 16:16 ` [PATCH v2 3/6] ArmVirtPkg/Kvmtool: Add DSDT ACPI table PierreGondois
2022-01-11 16:16 ` [PATCH v2 4/6] ArmVirtPkg/Kvmtool: Add Configuration Manager PierreGondois
2022-01-11 16:16 ` [PATCH v2 5/6] ArmVirtPkg/Kvmtool: Enable ACPI support PierreGondois
2022-01-11 16:16 ` [PATCH v2 6/6] ArmVirtPkg/Kvmtool: Enable Acpiview PierreGondois
2022-01-12 10:51 ` Ard Biesheuvel [this message]
2022-01-12 11:16   ` [PATCH v2 0/6] Add ACPI support for Kvmtool Ard Biesheuvel
2022-01-12 13:42     ` PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXGTx7VNmh_d7Svndooxz8DNCN=3+fLin4koXGchnau_1A@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox