From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.21872.1641984715812197769 for ; Wed, 12 Jan 2022 02:51:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MBeOuBFp; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF42FB81E96 for ; Wed, 12 Jan 2022 10:51:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADDB4C36AEC for ; Wed, 12 Jan 2022 10:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641984712; bh=x61ANb9ysz3gpiQ8GnF9a3tPiF+JHRawJYOMYngTP9I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MBeOuBFp0kDCBr3MAUhzYdqQm29/29QR3FqJLh+o4hGNOxGaRwIZlURVwC8dWuOLx qS0awy0khpsV2FHc6rAWMbxHZXUD7k/BlD/RcLqoIKwwpxIF8NMqm3WW8K2jibtgHZ UCy5hFo6fguE7PQeVacHG4AzXIZ8L0ClcfcGmEM3AD8zSGXHF00bIoFG2JdXQQ3vdj L1ZWzICrb4vcH2MuzdeaI/lwVmfQ2f0X9laeID9FEz3ILRsEZItsWfIHwE7PTU7oqW uT/dHweTY+crmgdy7Sz96pDH7G9x7PR2Tdjg7AXhPNeZ+fCzj4DHEc/GP971KJn5IY 9PsNXP/ZKMufA== Received: by mail-wr1-f46.google.com with SMTP id q8so3381965wra.12 for ; Wed, 12 Jan 2022 02:51:52 -0800 (PST) X-Gm-Message-State: AOAM530vHEUlF5m9jOVztaJDWujxGbH8SK5G8uahPOpbhURi7sNdBZOl Citukw3+KURq2GT8bJi1gGMe+tluc+cxN/wO/bU= X-Google-Smtp-Source: ABdhPJw+It4bSt26VG7/KZzPLTDkSjLMHs3XxNAXWj8pFlrbFeZs5eiEquYpFwfZuxi5O2loQSTMUg7lyaXNIkU7rDw= X-Received: by 2002:adf:f287:: with SMTP id k7mr7609280wro.417.1641984710951; Wed, 12 Jan 2022 02:51:50 -0800 (PST) MIME-Version: 1.0 References: <20220111161611.957688-1-Pierre.Gondois@arm.com> In-Reply-To: <20220111161611.957688-1-Pierre.Gondois@arm.com> From: "Ard Biesheuvel" Date: Wed, 12 Jan 2022 11:51:39 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/6] Add ACPI support for Kvmtool To: Pierre Cc: edk2-devel-groups-io , Ard Biesheuvel , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Tue, 11 Jan 2022 at 17:16, wrote: > > From: Pierre Gondois > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3742 > V1: https://edk2.groups.io/g/devel/message/76990 > V2: > - New patch: "DynamicTablesPkg: Print specifier macro for > CM_OBJECT_ID" [Laszlo] > - Only add AcpiView for ArmVirtKvmTool instead of all ArmVirt > platforms. This is done using a 'ACPIVIEW_ENABLE' switch. > [Laszlo] > - Only generate ACPI tables for AARCH64. [Laszlo] > - Various modifications (error handling, patch organization, > coding style, etc). [Laszlo] > > The changes can be seen at: https://github.com/PierreARM/edk2/tree/1456_Add_ACPI_support_for_Kvmtool_v2 > > Kvmtool dynamically generates a device tree describing the platform > to boot on. Using the patch-sets listed below, the DynamicTables > framework generates ACPI tables describing a similar platform. > > This patch-set: > - adds a ConfigurationManager and make use of the DynamicTablesPkg > in for Kvmtool for AARCH64, allowing to generate ACPI tables > - adds the acpiview command line utility to the ArmVirtPkg > platform that request if via the ACPIVIEW_ENABLE macro > - update ArmVirtPkg.ci.yaml to add new words and use the > DynamicTablesPkg > - adds a print specifier macro for the CM_OBJECT_ID type > > With this patchset, KvmTool on AARCH64 will use ACPI tables instead > of a Device Tree (cf PcdForceNoAcpi Pcd). > How did you test this? Can we boot Linux in ACPI mode with these changes? > Pierre Gondois (2): > DynamicTablesPkg: Print specifier macro for CM_OBJECT_ID > ArmVirtPkg: Add cspell exceptions > > Sami Mujawar (4): > ArmVirtPkg/Kvmtool: Add DSDT ACPI table > ArmVirtPkg/Kvmtool: Add Configuration Manager > ArmVirtPkg/Kvmtool: Enable ACPI support > ArmVirtPkg/Kvmtool: Enable Acpiview > > ArmVirtPkg/ArmVirt.dsc.inc | 5 +- > ArmVirtPkg/ArmVirtKvmTool.dsc | 22 +- > ArmVirtPkg/ArmVirtKvmTool.fdf | 15 +- > ArmVirtPkg/ArmVirtPkg.ci.yaml | 6 +- > .../KvmtoolCfgMgrDxe/AslTables/Dsdt.asl | 21 + > .../KvmtoolCfgMgrDxe/ConfigurationManager.c | 1061 +++++++++++++++++ > .../KvmtoolCfgMgrDxe/ConfigurationManager.h | 120 ++ > .../ConfigurationManagerDxe.inf | 54 + > .../Include/ConfigurationManagerObject.h | 7 +- > 9 files changed, 1303 insertions(+), 8 deletions(-) > create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl > create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.c > create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.h > create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf > > -- > 2.25.1