From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 50F977803CC for ; Thu, 3 Aug 2023 15:33:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KmBhVZYTl+vU/+WQ3O3KcsHbJHBwYJsNVorbYBheJJM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691076836; v=1; b=GNa/aXUAf9txovlpedaZ8UguxtEczuEB1Ng6i6ryoMDuPIqfGDvl+3UZI+nlEBQy9q6S3+gs plOFdmVX+s69TDM11pWv/UptF05c7mgP3+t8DO3Ev9BiImSigHjWpQ5OfyDW0tFsF0CxrZNSQE6 HbyXJGeIzCTB5Lr9vXVFipwE= X-Received: by 127.0.0.2 with SMTP id DuYoYY7687511xoUktKt7isL; Thu, 03 Aug 2023 08:33:56 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.17838.1691076836016140449 for ; Thu, 03 Aug 2023 08:33:56 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66AB961DCC for ; Thu, 3 Aug 2023 15:33:55 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE13DC433C7 for ; Thu, 3 Aug 2023 15:33:54 +0000 (UTC) X-Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2b9c66e2e36so14216401fa.1 for ; Thu, 03 Aug 2023 08:33:54 -0700 (PDT) X-Gm-Message-State: VV3foSUIiEFJROcuJ2s5WgtIx7686176AA= X-Google-Smtp-Source: APBJJlHpOmQLpsPoElLk9RjTnNdxN9ZnigBUNToB8k0XU6aPFHY0KebS+dl6hX+tidxh4IgL+zGTLbWkfLHzRwWq2H0= X-Received: by 2002:a05:651c:31c:b0:2b9:b1fb:5ff4 with SMTP id a28-20020a05651c031c00b002b9b1fb5ff4mr3143585ljp.21.1691076832834; Thu, 03 Aug 2023 08:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20230724201523.852-1-kuqin12@gmail.com> <3b648d9d-ddab-ba72-dd1e-e84f32c84f7e@gmail.com> In-Reply-To: <3b648d9d-ddab-ba72-dd1e-e84f32c84f7e@gmail.com> From: "Ard Biesheuvel" Date: Thu, 3 Aug 2023 17:33:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts To: Kun Qin , Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="GNa/aXUA"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 26 Jul 2023 at 20:45, Kun Qin wrote: > > Hi Ard, > > Our current use case is around AP core suspension and wake-ups. > > The program can suspend the secondary cores through PSCI interfaces > (after powering > them on). BSP can then wake up the suspended cores through SGI on demand. > The use of PSCI is already dubious in the context of UEFI - combining it with the use of SGIs for communication between cores seems like a slippery slope I don't think we should be going down. > The pending interrupt manipulation is to support BSP suspension and > wakeup. We > currently use watchdog timer to wake up suspended BSPs after a timeout. > suspended APs right? > Platforms can perform needed tasks during suspension, such as core power > consumption > analysis, in UEFI environment. > > Please let me if you have any suggestions. > Is there any basis in the UEFI or PI specifications for this functionality? > On 7/26/2023 1:45 AM, Ard Biesheuvel wrote: > > On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote: > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 > >> > >> This patch series introduce a few improvements related to interrupt > >> handling for ArmGic driver and library. > >> > >> 1. The current implementation of the `ArmGicSendSgiTo` is based on GIC v2 > >> and does not work on GIC v3 and on. > >> 2. The pending interrupt related primitives does not exist for end users. > >> > >> The change added the SGI support compatible with GIC v3 and v4. A few > >> pending interrupt related utility functions were also added. > >> > >> This change was tested on QEMU, FVP and proprietary hardware platforms. > >> > >> Pathc v1 branch: https://github.com/kuqin12/edk2/tree/improve_gic_v1 > >> > >> Cc: Leif Lindholm > >> Cc: Ard Biesheuvel > >> Cc: Sami Mujawar > >> > >> Kun Qin (3): > >> ArmPkg: ArmGic: Added support to send SGI to NS G1 EL1 > >> ArmPkg: ArmGicLib: Added GIC v3 and v4 support to ArmGicSendSgiTo > >> ArmPkg: ArmGic: Added functionalities to manipulate pending interrupts > >> > > Hello Kun, > > > > Could you please explain how this will be used by platforms? > > > > SGIs are only used by the MPcore SEC code, which is deprecated and > > shouldn't be used. And manipulating pending interrupts is another > > thing we should only support if there is a compelling use case. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107552): https://edk2.groups.io/g/devel/message/107552 Mute This Topic: https://groups.io/mt/100337221/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-