From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.19534.1680162115223784715 for ; Thu, 30 Mar 2023 00:41:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ldqi1Qlh; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ABED0B825F2 for ; Thu, 30 Mar 2023 07:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 790B3C4339B for ; Thu, 30 Mar 2023 07:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680162112; bh=CAEJnUPSdQNFGFwsw1nBWYziz3phsUmFzixEd6bEhHI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ldqi1QlhPwKNSycYVUC4ZK22vT8vqMPC6yGF5DB6rNIMujOeq1/r4KKjIpCeW206Z 8LwFpdeQH6XewMPY3oycse/c3NgoEPDA3g9G4BsNpM3whflIR/GpILm0v4uDCSz9gf 2vCEfunMS2GPnPVm51ouTewm0YXCMQc0SsOiIlpj/muzTw3C9utteEwpo7YD3nKDyl hewSUzOad6yvSbCoK2L3AR6GIRpqqVLnyGv7eRJLtmhtCwuWwIOYvLOwD0iv/W+2WC FTYsD3fpmQQ1tjtLL3PeoI9vpl+FMkGel65DxcGzWFrmyKrWSOHF+5CQTzRa4AkK+6 oh8pGTXoiys7A== Received: by mail-lf1-f41.google.com with SMTP id h25so23367258lfv.6 for ; Thu, 30 Mar 2023 00:41:52 -0700 (PDT) X-Gm-Message-State: AAQBX9ciqObBYsoz2m8m6gL6ygZZNzcBWqqZlj7IvUOb9UfGOhKb5rws WsvIO/CZmlzWooKL0PJ7YKYRBerW4/oihppJpnQ= X-Google-Smtp-Source: AKy350bbWQ+bwbB2U9NI61TvqDBpE2L+Em5ikacgdvfIRVUuUHzxIGgmjbBTOwDR2eT8AFkiHdBay9o2m5E1m/Z5ulI= X-Received: by 2002:ac2:4c34:0:b0:4e9:a71d:3edb with SMTP id u20-20020ac24c34000000b004e9a71d3edbmr6551754lfq.9.1680162110508; Thu, 30 Mar 2023 00:41:50 -0700 (PDT) MIME-Version: 1.0 References: <20230327110112.262503-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 30 Mar 2023 09:41:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table To: devel@edk2.groups.io, quic_llindhol@quicinc.com, Rebecca Cran , Michael Kinney , Liming Gao , Jiewen Yao Cc: Michael Kubacki , Sean Brogan , Sami Mujawar , Taylor Beebe , =?UTF-8?Q?Marvin_H=C3=A4user?= , Bob Feng Content-Type: text/plain; charset="UTF-8" On Wed, 29 Mar 2023 at 18:31, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:00:55 +0200, Ard Biesheuvel wrote: > > Implement version 2 of the memory attributes table, which now contains a > > flag informing the OS whether or not code regions may be mapped with CFI > > mitigations such as IBT or BTI enabled. > > > > This series covers roughly the following parts: > > > > - (AARCH64) Annotate ELF objects generated from asm as BTI compatible > > when BTI codegen is enabled > > - Update the BaseTools to emit the appropriate PE/COFF annotation when a > > BTI/IBT compatible ELF executable is converted to PE/COFF > > - Take this PE/COFF annotation into account when populating the memory > > attributes table in the DXE core > > For any patches I haven't explicitly commented on in this set: > Reviewed-by: Leif Lindholm > > (but I did comment on patch 17 in the review of patch 15) > Thanks. I have pushed the AArch64 specific codegen changes and the MdePkg one that updates the definition of the table. That leaves the following changes: BaseTools/GenFw: Parse IBT/BTI support status from ELF note BaseTools/GenFw: Add DllCharacteristicsEx field to debug data Liming, Bob, Rebecca: any comments here? MdePkg/PeCoffLib: Capture DLL characteristics fieldis in image context MdeModulePkg: Enable forward edge CFI in mem attributes table Jiewen, Liming?