From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.5097.1650440452649395228 for ; Wed, 20 Apr 2022 00:40:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VQJZMjt7; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C8836186D for ; Wed, 20 Apr 2022 07:40:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56F1BC385A8 for ; Wed, 20 Apr 2022 07:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650440451; bh=SFKZpkFhGEgNkRoNLRqFTdOlYdAHgu3MjAN+UoF3Bqo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VQJZMjt7VNERNSESAKXDpbdLhOj6WRYsoKoiqwX1G19CcmVVhqTE5SKlsEWQPKfPU UxpH18ay3jionNa9/rklVKv6Tn/qaEwsYRgYCj3rwnV8vsA/bHX8LZvyP1U6UoaRzB 33BnG7iZpWZpmiutJSVnK7uzZX01Pk7tpPFrff4nCzDey1OmFnfXbilhx204emMM5d FjZttWQWis3xv5nGF+DVpu7ZLcboOepqrIs/T1iIEOiSGFIaGTrzLIx4ojQ//y/qQC WabmJCE6fm1r4qcSY8rfk1iQarilnVuiAGFRng9EvWuQXIE0q5uStcMpRgPZg72c1p WsFEvlGWzwHxA== Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-deb9295679so1134797fac.6 for ; Wed, 20 Apr 2022 00:40:51 -0700 (PDT) X-Gm-Message-State: AOAM530y3OBOFyoIOJcQ5llVzuZLx93vzmEFYGsiHhRVIR+BSR1+ChxZ qeibvmg5rXZXA09ioBclcpvKSlAJQFteWHQgLHM= X-Google-Smtp-Source: ABdhPJxRycmi+2k4sMFRNOeAts96z9nOJ9eeU0ib8ortLj5CKRHqFV+ENd2ivmRRTuB8K1vNyXw6pOjAj9Pz7xWpafg= X-Received: by 2002:a05:6871:297:b0:e5:f100:602f with SMTP id i23-20020a056871029700b000e5f100602fmr1046818oae.126.1650440450501; Wed, 20 Apr 2022 00:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220418115431.30602-1-pranav.madhu@arm.com> In-Reply-To: <20220418115431.30602-1-pranav.madhu@arm.com> From: "Ard Biesheuvel" Date: Wed, 20 Apr 2022 09:40:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms][PATCH V2 0/9] Upadate the ACPI tables for RD platforms To: Pranav Madhu Cc: edk2-devel-groups-io , Ard Biesheuvel , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Mon, 18 Apr 2022 at 13:54, Pranav Madhu wrote: > > Changes since V1: > - Rebased on top of latest master branch. > - Rebased on top of patch to remove SLC cache entries from PPTT (link > for the same in edk2.groups.io is provided below) > > Arm infrastructure reference design platforms uses ACPI tables to > provide the hardware information to the operating system. Currently the > ACPI tables are aligned with ACPI v6.2 and v6.3 specification. This > patch series update the tables to ACPI v6.4 specificaion. > Why is this necessary? By doing this, you will lose the ability to boot an OS that implements ACPI 6.2 but not ACPI 6.4, and so this should only be done if you are actually relying on a feature that was not available in ACPI 6.2. Otherwise, this is just pointless busywork. > The first patch in this series update the generic tables which are > common for all platfoms. The subsequent patches in this series update > platform specific ACPI tables to v6.4 for the respective platform. > > This patch series also update the headers in the .aslc files to match > the coding style as per edk2 coding guidelines. > > This patch series should be applied on top of the patch series > https://edk2.groups.io/g/devel/message/88996 > > Link to github branch with the patches in this series - > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/acpi64_for_rd_platforms > > > Pranav Madhu (9): > Platform/Sgi: Update ACPI version to v6.4 > Platform/Sgi: Update ACPI version to v6.4 for SGI-575 platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-N1-Edge platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-N1-Edge-X2 platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-E1-Edge platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-V1 platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-V1-MC platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-N2 platform > Platform/Sgi: Update ACPI version to v6.4 for Rd-N2-Cfg1 platform > > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 219 ++++++++-------- > Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc | 30 ++- > Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc | 38 +-- > Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc | 69 ++--- > Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc | 26 +- > .../ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 247 +++++++++--------- > .../ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 106 ++++---- > .../ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc | 105 ++++---- > .../ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 88 ++++--- > .../SgiPkg/AcpiTables/RdN1EdgeX2/Hmat.aslc | 52 ++-- > .../SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 151 ++++++----- > .../SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc | 92 +++---- > .../SgiPkg/AcpiTables/RdN1EdgeX2/Srat.aslc | 74 +++--- > Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc | 163 ++++++------ > Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 77 +++--- > .../ARM/SgiPkg/AcpiTables/RdN2Cfg1/Madt.aslc | 112 ++++---- > .../ARM/SgiPkg/AcpiTables/RdN2Cfg1/Pptt.aslc | 73 +++--- > Platform/ARM/SgiPkg/AcpiTables/RdV1/Madt.aslc | 159 +++++------ > Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 77 +++--- > .../ARM/SgiPkg/AcpiTables/RdV1Mc/Hmat.aslc | 64 +++-- > .../ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc | 165 ++++++------ > .../ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc | 81 +++--- > .../ARM/SgiPkg/AcpiTables/RdV1Mc/Srat.aslc | 82 +++--- > .../ARM/SgiPkg/AcpiTables/Sgi575/Madt.aslc | 105 ++++---- > .../ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc | 86 +++--- > Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 29 +- > 26 files changed, 1343 insertions(+), 1227 deletions(-) > > -- > 2.17.1 >