From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web09.9345.1661336082401101334 for ; Wed, 24 Aug 2022 03:14:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KtGZfjPU; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CBB9DB8239C for ; Wed, 24 Aug 2022 10:14:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C668C433B5 for ; Wed, 24 Aug 2022 10:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661336078; bh=UphcySJ6KiKtAX5McuUOWlIqK5BJQFSyE2NgzjpTdyI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KtGZfjPUuRSGgp2MfZddigpxqTH9JL91r85I2K+xiqrUFSwj50T3G7lQxkMpPoxRq HwdUv0WXj43QoUUs+RZe4QDOIvl7McHgV/4r9SbjAVWrXPeboNJdQWtlDAvhYEWEYs Y7cb9A3kscPIElnEx1USoeLQjHfs/7OrEdllym/Hn6GSvbERr9kBMOcBY5EdP+xrhu TxdgjUSi/6stklMlU7W8RjJljbOPJth46o7oIw2GfZa/VSBzEdYxXa9XdrrzCq8eYX Dcq/XrrOAsQ2DNpw3iqTecyPMAC0uAuX6Lm+OwQMGvr24hwho/+wv9252sb8qwToVl nstE/D7P7rVeA== Received: by mail-wm1-f47.google.com with SMTP id ay12so8524085wmb.1 for ; Wed, 24 Aug 2022 03:14:38 -0700 (PDT) X-Gm-Message-State: ACgBeo02FT2IA/9vVFWhK+0NEU0Kg/3NNVC2TF1xINUiaDjgXngGBJnb MiAFJIPhZ6vkJpNAi9WNq38iywKqyz3gG49eTo4= X-Google-Smtp-Source: AA6agR4O01FXNlxJkZ7ffteDtuOAyr8nyNHOMDCnFhAe27MzvAMOhfU5Sox6PSCCTKA63BMqDtyyIBre4bmjgn5/hnA= X-Received: by 2002:a05:600c:3586:b0:3a5:fb24:a205 with SMTP id p6-20020a05600c358600b003a5fb24a205mr4883713wmq.77.1661336076882; Wed, 24 Aug 2022 03:14:36 -0700 (PDT) MIME-Version: 1.0 References: <41a26d57-4fae-f53f-29ae-d6c7b258eaee@bsdio.com> <000a01d8b693$58d87c60$0a897520$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 24 Aug 2022 12:14:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu 22.04 To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: "Gao, Liming" , "rebecca@bsdio.com" , "Chen, Christine" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" Content-Type: text/plain; charset="UTF-8" On Wed, 24 Aug 2022 at 09:49, Ard Biesheuvel wrote: > > On Tue, 23 Aug 2022 at 09:41, Bob Feng wrote: > > > > Hi Liming, > > > > Reverting patch may not a good idea, some platforms have done the implementation based on the DSC spec, if revert, those platforms build will break. > > Platforms implemented against the DSC spec would have never worked if > they relied on behavior that BaseTools currently does not implement. > > > This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the Basetools behavior be consistent with DSC spec so I don't think it's a regression bug. > > > > Platforms built against the current behavior that used to work might > break after this change. MdeModulePkg.dsc for ARM/AARCH64 no longer > builds due to this change. > > Also, as I pointed out, the DSC spec is far from ambiguous. Ugh I did it again ... "far from *un*ambiguous" Will use less difficult words from now on - I obviously cannot be trusted with them. > This means > that platforms implemented against the spec will rely on one of > several possible interpretations of that ambiguous set of rules. > > So let's revert this change now. Let's fix the DSC spec next, And only > then, let's fix the code (assuming it still needs to be fixed) > > -- > Ard.