From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73B5178003C for ; Thu, 25 Jul 2024 21:23:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+4VG39Cw4qx9txZDLvwkG2DNkwoSfeZqCoTEuHdhYnU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1721942604; v=1; b=M9PH+uknGyUEvrkRZ/lARpemQXFZ74AUPnuroMqhUnAMdXrTBUt1VsS09cS2OOMkzM39aUa8 ZdpmhsAmTuhGZMJ0/n8ZAkfdBbVvJvr6kab2KbTXKOum7s5mLl8eX1JEUV8zSBS3BvcdOXNiWzf wwVGkjhPhglNPOxd3wsxWC+XANg+YZQe97GGV2HLCgGeDYcxogtxyRrV+G0TcvnTbAZh9kP22cX LPBUyf9G5TMbwvnToTNkT57jV/g9fzz4m6GqyVWbKt6GQzp+CNS/fnZ8NEzn+iI2+FW191AL160 hGEvZhuCw9GdT2z8aGun0znVQV0IL5YTHCp0VR8Gdd+Cw== X-Received: by 127.0.0.2 with SMTP id wxOGYY7687511x6GCXUonwPf; Thu, 25 Jul 2024 14:23:22 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.47681.1721942601702391818 for ; Thu, 25 Jul 2024 14:23:22 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D9B0FCE1684 for ; Thu, 25 Jul 2024 21:23:18 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33D19C4AF0A for ; Thu, 25 Jul 2024 21:23:18 +0000 (UTC) X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52efa9500e0so780201e87.3 for ; Thu, 25 Jul 2024 14:23:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXdQW2s563gIiTqz8yi3ij+hLPZrvlFNs863//tEO7m/aTdbwOJw1gjqTcAcYCdih2UgxEvHNbJ3HHLzKnUYk1xZUvPyA== X-Gm-Message-State: uqZoHerxwzcqtqeadAqTFSgtx7686176AA= X-Google-Smtp-Source: AGHT+IEeXymogO4I+qIHEZYd47mKIc580y8fFnuDVsW0cR1d0cfKbIWns8d0PBkbHCyuQ31DuPIwuJTFPmkJwDy345k= X-Received: by 2002:a05:6512:3504:b0:52e:a60e:3a08 with SMTP id 2adb3069b0e04-52fd601881amr2272859e87.11.1721942596505; Thu, 25 Jul 2024 14:23:16 -0700 (PDT) MIME-Version: 1.0 References: <20240725104332.1675625-1-ardb+git@google.com> <20240725104332.1675625-6-ardb+git@google.com> <7d3a04a4-f33a-4095-8390-bc77229caf5e@arm.com> In-Reply-To: <7d3a04a4-f33a-4095-8390-bc77229caf5e@arm.com> From: "Ard Biesheuvel" Date: Thu, 25 Jul 2024 23:23:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib To: Jeremy Linton Cc: Leif Lindholm , Ard Biesheuvel , devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Jul 2024 14:23:22 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=M9PH+ukn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 25 Jul 2024 at 22:21, Jeremy Linton wrote: > > Hi, > > On 7/25/24 06:38, Leif Lindholm wrote: > > On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: > >> From: Ard Biesheuvel > >> > >> Drop the now unused EfiResetSystemLib implementation, which has been > >> superseded by the generic one from EDK2. > >> > >> Signed-off-by: Ard Biesheuvel > >> --- > >> Platform/RaspberryPi/RaspberryPi.dec | 1 - > >> Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf | 1 - > >> Platform/RaspberryPi/Library/ResetLib/ResetLib.inf | 45 ------ > >> Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.c | 11 -- > >> Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 151 -------------------- > >> 5 files changed, 209 deletions(-) > >> > >> diff --git a/Platform/RaspberryPi/RaspberryPi.dec b/Platform/RaspberryPi/RaspberryPi.dec > >> index 6bd16a5ae9fd..a5fa1fb00c48 100644 > >> --- a/Platform/RaspberryPi/RaspberryPi.dec > >> +++ b/Platform/RaspberryPi/RaspberryPi.dec > >> @@ -24,7 +24,6 @@ [Protocols] > >> > >> [Guids] > >> gRaspberryPiTokenSpaceGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}} > >> - gRaspberryPiEventResetGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB4, 0xB4, 0xE4, 0xD4, 0xB4}} > >> gConfigDxeFormSetGuid = {0xCD7CC258, 0x31DB, 0x22E6, {0x9F, 0x22, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}} > > > > *loud sigh at looking those "GUIDs"* > > But that's not this set's fault. > > The first couple are DCE time/mac UUIDs with the MAC address fuzzed, no? > Initially I assumed this coudn't be the case because I would have > expected the timestamp (2016-06-13 21:57:59, which looks almost > reasonable) to vary, but i'm guessing they were generated, and then > someone didn't want their mac in the pubic so they fuzzed it a couple > times rather than generating completely new IDs. Some of the others > though, maybe a BE/LE UUID/GUID manual conversion (or not) problem... > It looks to me like "hey I need a new GUIO so I'll just grab this one and stick some 2s or some 4s in random places" > Anyway, I will spin it up in a day or two on real hardware, but right > now its all torn down in boxes because i've moved. > Thanks. I'll do the same myself on Sunday or Monday - am travelling at the moment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120043): https://edk2.groups.io/g/devel/message/120043 Mute This Topic: https://groups.io/mt/107540912/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-