From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.50432.1683208966218480734
 for <devel@edk2.groups.io>;
 Thu, 04 May 2023 07:02:46 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KoJr7JDU;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id BDD8663295
	for <devel@edk2.groups.io>; Thu,  4 May 2023 14:02:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4022C433A7
	for <devel@edk2.groups.io>; Thu,  4 May 2023 14:02:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1683208962;
	bh=FkzpTyWKBVSjGXk0E4WnnnDDzwFUk3PDFzrAhC61Xyc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=KoJr7JDUElEAwBD/jwdW11C/M4bCezJRc3TY2C7T29wWqu0oYEOzH11PZQlY9yOPZ
	 E1vPvyk9vLHaSm4yhfAnwfVhveAH9yVU4N4eWEQwQGwj5dkCXsXBJFdblTaG0LJk3y
	 As6l98igLoWG1xF4E90c8z/1721RWGmhLXxu+hHhc+kjIJYRqQzpsDpsYC2sLiioLt
	 9nD0n34pdsUiK6mxq67zLDy36kp9AgSNcE27W1pRiWg4wRAxxQknYf7viuYkuH+dor
	 A8JuKTOf+dStXSTlSnnC9hX6mheLwK89fyMVhV7aeMpKtRfSSmCQMYwcfYFWEl5kvY
	 zzl6tVWdfZLng==
Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4ec9c7c6986so627258e87.0
        for <devel@edk2.groups.io>; Thu, 04 May 2023 07:02:42 -0700 (PDT)
X-Gm-Message-State: AC+VfDzXbuDQxn6OvlAB6wNQFQ+OjopPzIZBzPCZ+3Jv2WAeZ/1mZMtw
	IAzTNHKT3ZhiZacFavhLaOIroIEJLnlbG3aAPPU=
X-Google-Smtp-Source: ACHHUZ7Zd7ZVWN8lOjpYYcLsGx79DuuzLR/Y9WCdIc6z8Rqz6s/Kh8uC7TWk4rRLb7K6vWtTjw7DSZzdiRRyZQxaRL4=
X-Received: by 2002:ac2:4a6f:0:b0:4f1:1e18:f7fe with SMTP id
 q15-20020ac24a6f000000b004f11e18f7femr1887081lfp.20.1683208960690; Thu, 04
 May 2023 07:02:40 -0700 (PDT)
MIME-Version: 1.0
References: <20230504133251.1031341-1-kraxel@redhat.com>
In-Reply-To: <20230504133251.1031341-1-kraxel@redhat.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 4 May 2023 16:02:29 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGYNQOPAMgMKqXxPPVnnMU=CdnxCRoE5ynn2Mkrn6zmoA@mail.gmail.com>
Message-ID: <CAMj1kXGYNQOPAMgMKqXxPPVnnMU=CdnxCRoE5ynn2Mkrn6zmoA@mail.gmail.com>
Subject: Re: [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>, 
	Erdem Aktas <erdemaktas@google.com>, Min Xu <min.m.xu@intel.com>, 
	Tom Lendacky <thomas.lendacky@amd.com>, Jordan Justen <jordan.l.justen@intel.com>, 
	Stefan Berger <stefanb@linux.ibm.com>, Julien Grall <julien@xen.org>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Oliver Steffen <osteffen@redhat.com>, 
	James Bottomley <jejb@linux.ibm.com>, Pawel Polawski <ppolawsk@redhat.com>, 
	Michael Roth <michael.roth@amd.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 4 May 2023 at 15:33, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> An attempt to reduce code duplication a bit.  PlatformBootManagerLibGrub
> is an (outdated) copy of PlatformBootManagerLib with some policy
> changes.  Add a PCD to enable this policy and add support for that to
> PlatformBootManagerLib, which in turn allows to remove
> PlatformBootManagerLibGrub.
>
> Gerd Hoffmann (3):
>   OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware
>   OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub
>   OvmfPkg: drop PlatformBootManagerLibGrub
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>


>  OvmfPkg/OvmfPkg.dec                           |    3 +
>  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   10 +-
>  .../PlatformBootManagerLib.inf                |    2 +
>  .../PlatformBootManagerLibGrub.inf            |   73 -
>  .../PlatformBootManagerLibGrub/BdsPlatform.h  |  185 --
>  .../PlatformBootManagerLib/BdsPlatform.c      |   70 +-
>  .../PlatformBootManagerLibGrub/BdsPlatform.c  | 1604 -----------------
>  .../PlatformBootManagerLibGrub/PlatformData.c |  212 ---
>  .../PlatformBootManagerLibGrub/QemuKernel.c   |   55 -
>  9 files changed, 79 insertions(+), 2135 deletions(-)
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformBootManagerLibGrub.inf
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformData.c
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c
>
> --
> 2.40.1
>