From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.5675.1632309615547456174 for ; Wed, 22 Sep 2021 04:20:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MhYgovnk; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id BA16E6112F for ; Wed, 22 Sep 2021 11:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632309614; bh=GmBPR+VzhLaADNRdPVe87bxOfp6yqoWQgut2jqB3RLk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MhYgovnkfig/SuBRsz+Ji+leYL/5yMlTR93cGeBkJpkygLWWQFBzTHdt/yDMlGW8f JxL8v3y2Z2i/1hN7xE9vie2H31V5BQM2VEGJA2AzyQ5Zi/Dh1/qjWXgdl56Rl3ft0b G5EuGaEIqbTlfQU0BRGgseAOunCOxuxDsVh2UnwjNPiz5P8SYr6pQ6w7bPNOQOUPDE CFDyWKW5MpMIURlQVM5UhCDm4bgigZ4KooyYK0DlWC6r0sUEoE6IehyfPRTFGuFdpa Y5/C9MeqIh1Msr4MLo942xMmHJsS7Ph909nlLwwEcpBT4YsQb/ghOmvujNKl839EYG L70oCuIrhLxQA== Received: by mail-oo1-f53.google.com with SMTP id l17-20020a4ae391000000b00294ad0b1f52so763111oov.10 for ; Wed, 22 Sep 2021 04:20:14 -0700 (PDT) X-Gm-Message-State: AOAM530S+iF+ANB7WHlOByzseSK4FYLRIaJ0Wx3en1xN5S7gE14hx7YT U/3JCAUbJ3JsPtrz+lZCSYIj5Pyu5UJpYZ3gwmo= X-Google-Smtp-Source: ABdhPJxO7F9+uLljlG3TJ6TN2Y41IFTw7UGxBhpEY4BvpP0/Grxf2KKBZih849y2wzPKs+YBOt1oks4s+GfNysGPSzM= X-Received: by 2002:a4a:11c6:: with SMTP id 189mr28469695ooc.32.1632309614126; Wed, 22 Sep 2021 04:20:14 -0700 (PDT) MIME-Version: 1.0 References: <20210911025714.26263-1-rebecca@bsdio.com> <20210911025714.26263-2-rebecca@bsdio.com> <20210914143903.ors7du74byx2zirx@leviathan> In-Reply-To: <20210914143903.ors7du74byx2zirx@leviathan> From: "Ard Biesheuvel" Date: Wed, 22 Sep 2021 13:20:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 1/4] BeagleBoardPkg: Remove the configuration and image headers from flash To: Leif Lindholm Cc: Rebecca Cran , Ard Biesheuvel , edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Tue, 14 Sept 2021 at 16:39, Leif Lindholm wrote: > > Ard, I think you were the one who converted the old crazy header stuff > to what we have now. Do you remember how this all fits together? > I had to page it in (edk2:a1123292a80608a69df89b6dd264c4656b618aec) but given that I never used a BeagleBoard in my life, I'm sure this was a theoretical exercise mostly, and I just compared the resulting images before and after. So this looks fine to me - if don't have a use for the configuration header we should just remove it. > For the *other* 3 patches, but not this one: > Reviewed-by: Leif Lindholm > > > On Fri, Sep 10, 2021 at 20:57:11 -0600, Rebecca Cran wrote: > > Remove the configuration and image headers from the flash image. > > This was likely intended for the UEFI firmware to be loaded by the ROM > > code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be > > executed as a second stage loader. > > > > Signed-off-by: Rebecca Cran > > --- > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf | 13 ++----------- > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > index a2cfeb3bc27b..dbae015ff382 100644 > > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > @@ -23,7 +23,7 @@ > > > > > > [FD.BeagleBoard_EFI] > > -BaseAddress = 0x80007DF8|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > > +BaseAddress = 0x80008000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > > Size = 0x000B0000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device > > ErasePolarity = 1 > > BlockSize = 0x1 > > @@ -44,16 +44,7 @@ NumBlocks = 0xB0000 > > # RegionType > > # > > ################################################################################ > > -0x00000000|0x00000200 > > -FILE = Platform/BeagleBoard/BeagleBoardPkg/ConfigurationHeader.bin > > - > > -0x00000200|0x00000008 > > -DATA = { > > - 0xF8, 0xFD, 0x0A, 0x00, # image size: 0xB0000 - 0x208 == 0xAFDF8 > > - 0x00, 0x80, 0x00, 0x80 # entry point: 0x80008000 > > -} > > - > > -0x00000208|0x000AFDF8 > > +0x00000000|0x000B0000 > > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > FV = FVMAIN_COMPACT > > > > -- > > 2.31.1 > > > >