From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.5749.1632310808615064512 for ; Wed, 22 Sep 2021 04:40:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gQpLDHKG; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 69CC561107 for ; Wed, 22 Sep 2021 11:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632310807; bh=FW+fhqrme+R8u3QUxxc7bfoEWQGOd9scRR1Gh43vYTA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gQpLDHKGKByynjdBfi4F4lde9Iyxa9igwg7Iw4P5t+uf5Wy4VSEuLZfNQ7j7tmf8g CbBGK7re4Qo58Y1IuJTs0xT1w0/CT6+4/k6GC7PNfJg5BFxA0kjVbvtll5kpaP2LD+ KJpkRMJ5ZmXWikVPxao6/oGfDRyGzsAeNkSjc09BsaHVwpgQYUYwYw4fsgShhlMYcp Af1jnjmRXm4O4kulrJ0HpgU/YW1b7WOSF3fcORn0X1CMDyCu8PS+MIHvAm7y5usCIJ y678hmHB6PXNlDRMbus+l+t9Dbzi/qzVxxaIg/TBvP5g9pg6jXzMzUmG+QPDOZlboY 1pq/+GN4MQAfg== Received: by mail-oo1-f43.google.com with SMTP id b5-20020a4ac285000000b0029038344c3dso782934ooq.8 for ; Wed, 22 Sep 2021 04:40:07 -0700 (PDT) X-Gm-Message-State: AOAM530YPpOZyxktHqgo5CSANtDH9Q6RgdhIWCtD6J+qzWtD+dUKUJDv DXSa1PKUXI//riao+XdDJm0faltI9VXOlsMxZO4= X-Google-Smtp-Source: ABdhPJzq7Q6obIC2XFrcVcPYmq6hmL3FAWhIFbvdqe4OG28eDx+/vp/mifL9sSqNnlqOBd0nz7UigunAIgYZuzK0Ie4= X-Received: by 2002:a4a:11c6:: with SMTP id 189mr28540125ooc.32.1632310806797; Wed, 22 Sep 2021 04:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20210916211752.2714332-1-stefanb@linux.ibm.com> <20210916211752.2714332-2-stefanb@linux.ibm.com> <7fae5700-234e-5b63-6d36-19a3c393148f@linux.ibm.com> In-Reply-To: <7fae5700-234e-5b63-6d36-19a3c393148f@linux.ibm.com> From: "Ard Biesheuvel" Date: Wed, 22 Sep 2021 13:39:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib To: edk2-devel-groups-io , Stefan Berger Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Gerd Hoffmann , Jiewen Yao , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Stefan Berger Content-Type: text/plain; charset="UTF-8" On Sat, 18 Sept 2021 at 13:54, Stefan Berger wrote: > > > On 9/18/21 3:55 AM, Ard Biesheuvel wrote: > > On Thu, 16 Sept 2021 at 23:18, Stefan Berger wrote: > >> From: Stefan Berger > >> > >> Add a NULL implementation of the library class TpmPlatformHierarchyLib. > >> > > This patch introduces both the library class and the NULL > > implementation, right? > > No, we already added the library class when adding the 'foundation' for > x86 support: > https://github.com/tianocore/edk2/tree/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib > > > > > >> Cc: Ard Biesheuvel > >> Cc: Leif Lindholm > >> Cc: Sami Mujawar > >> Cc: Gerd Hoffmann > >> Signed-off-by: Stefan Berger > >> --- > >> ArmVirtPkg/ArmVirtPkg.dec | 1 + > >> .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++++++++++++++++ > >> .../PeiDxeTpmPlatformHierarchyLib.c | 22 ++++++++++++++ > >> .../PeiDxeTpmPlatformHierarchyLib.inf | 30 +++++++++++++++++++ > >> 4 files changed, 80 insertions(+) > >> create mode 100644 ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > >> create mode 100644 ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > >> create mode 100644 ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > >> > >> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec > >> index 4e4d758015..f3bdca118b 100644 > >> --- a/ArmVirtPkg/ArmVirtPkg.dec > >> +++ b/ArmVirtPkg/ArmVirtPkg.dec > >> @@ -27,6 +27,7 @@ > >> > >> [LibraryClasses] > >> ArmVirtMemInfoLib|Include/Library/ArmVirtMemInfoLib.h > >> + TpmPlatformHierarchyLib|Include/Library/TpmPlatformHierarchyLib.h > >> > >> [Guids.common] > >> gArmVirtTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } } > >> diff --git a/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h b/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > >> new file mode 100644 > >> index 0000000000..8d61a4867b > >> --- /dev/null > >> +++ b/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > >> @@ -0,0 +1,27 @@ > >> +/** @file > >> + TPM Platform Hierarchy configuration library. > >> + > >> + This library provides functions for customizing the TPM's Platform Hierarchy > >> + Authorization Value (platformAuth) and Platform Hierarchy Authorization > >> + Policy (platformPolicy) can be defined through this function. > >> + > >> +Copyright (c) 2019, Intel Corporation. All rights reserved.
> >> +Copyright (c) Microsoft Corporation.
> >> +SPDX-License-Identifier: BSD-2-Clause-Patent > >> + > >> +**/ > >> + > >> +#ifndef TPM_PLATFORM_HIERARCHY_LIB_H_ > >> +#define TPM_PLATFORM_HIERARCHY_LIB_H_ > >> + > >> +/** > >> + This service will perform the TPM Platform Hierarchy configuration at the SmmReadyToLock event. > >> + > >> +**/ > >> +VOID > >> +EFIAPI > >> +ConfigureTpmPlatformHierarchy ( > >> + VOID > >> + ); > >> + > >> +#endif > >> diff --git a/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > >> new file mode 100644 > >> index 0000000000..bac1efda63 > >> --- /dev/null > >> +++ b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > >> @@ -0,0 +1,22 @@ > >> +/** @file > >> + Null TPM Platform Hierarchy configuration library. > >> + > >> + This library provides stub functions for customizing the TPM's Platform Hierarchy. > >> + > >> + Copyright (c) 2021, IBM Corporation. > >> + SPDX-License-Identifier: BSD-2-Clause-Patent > >> + > >> +**/ > >> + > >> +#include > >> + > >> +/** > >> + A NULL implementation of ConfigureTpmPlatformHierarchy. > >> +**/ > >> +VOID > >> +EFIAPI > >> +ConfigureTpmPlatformHierarchy ( > > VOID > Ok , had copied signature 1:1 from here: > https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c#L239 > > > >> + ) > >> +{ > >> + /* no nothing */ > > double negative :-) > > > Typo. Will fix. > > > > >> +} > >> diff --git a/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > >> new file mode 100644 > >> index 0000000000..4f02818bbc > >> --- /dev/null > >> +++ b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > >> @@ -0,0 +1,30 @@ > >> +### @file > >> +# NULL TPM Platform Hierarchy configuration library. > >> +# > >> +# This library provides functions for customizing the TPM's Platform Hierarchy > >> +# Authorization Value (platformAuth) and Platform Hierarchy Authorization > >> +# Policy (platformPolicy) can be defined through this function. > >> +# > >> +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> >> +# Copyright (c) Microsoft Corporation.
> >> +# > >> +# SPDX-License-Identifier: BSD-2-Clause-Patent > >> +# > >> +### > >> + > >> +[Defines] > >> + INF_VERSION = 0x00010005 > > 1.27 > Originally all comes from this file here: > https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf#L16 > Doesn't matter. New INFs use the latest version > > >> + BASE_NAME = PeiDxeTpmPlatformHierarchyLibNull > > Make this BasePlatform.... > > Even though it will be different than here? > https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf#L17 > Yes. > > > > > >> + FILE_GUID = 8947A3F2-BfB4-45EF-968D-5C40C1CE6A58 > >> + MODULE_TYPE = PEIM > > BASE > > > >> + VERSION_STRING = 1.0 > >> + LIBRARY_CLASS = TpmPlatformHierarchyLib|PEIM DXE_DRIVER > >> + > >> +[LibraryClasses] > >> + BaseLib > >> + > >> +[Packages] > >> + MdePkg/MdePkg.dec > >> + > >> +[Sources] > >> + PeiDxeTpmPlatformHierarchyLib.c > >> -- > >> 2.31.1 > >> > >> > >> > >> ------------ > >> Groups.io Links: You receive all messages sent to this group. > >> View/Reply Online (#80830): https://edk2.groups.io/g/devel/message/80830 > >> Mute This Topic: https://groups.io/mt/85662429/5717338 > >> Group Owner: devel+owner@edk2.groups.io > >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > >> ------------ > >> > >> > > > > >