From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.9844.1672996501768892315 for ; Fri, 06 Jan 2023 01:15:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gGdam5wk; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A899261D60 for ; Fri, 6 Jan 2023 09:15:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 152BEC433EF for ; Fri, 6 Jan 2023 09:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672996500; bh=LwIb75rKNDoVMjXtLasbwgKak7mwnP2DBrczRCWVShA=; h=References:In-Reply-To:From:Date:Subject:To:From; b=gGdam5wkIzXXp1wqUMKei4FjeV0wHWuWwiqdxtt5VgSR3jab/kS9S/rbYXYXYtbal qj7Ow1qmvYALTEi8X39lqeeKBlM6ckUKglxXnmjDrz5M+cAZ4kiNewN90ogtFjMWYy 7xnyBhIP5BLi2wX0PDEX415ODsJdw6Eww1DyTsX2bQ1X+bsg0IhwmGsgagi87uwhWn MJZCaod7cgHyvcvlaqKBqmCYY5BQpHuaYcAbvC6rUpuf/ybMmctrbFlYTiE6m74O26 yAIXGzTGvoBAZ0ipBXthgEPHLJqw8n9ISl81L/47pTgBK/2fBCXp8mLznICRSc3sbm 4etjcn7hBDNTw== Received: by mail-lj1-f176.google.com with SMTP id x11so877652ljh.12 for ; Fri, 06 Jan 2023 01:14:59 -0800 (PST) X-Gm-Message-State: AFqh2kqmKyoGFLiTBTRnCzAeZhvLGLsJZLdVgWiPtWhwcKgberv0lKJM VMH3CzfCBNMVyc0vUhiOnE5fThQq8irYaBGtPk0= X-Google-Smtp-Source: AMrXdXt63IvYmUwQdRtxEOXBnPrOKuB79V6kOwHW+2aIIoFcBLgJIjS1R5J26WihKEU4csXfYiGynMv+IOnE+uwQTSA= X-Received: by 2002:a05:651c:1987:b0:281:acef:7806 with SMTP id bx7-20020a05651c198700b00281acef7806mr126928ljb.516.1672996498070; Fri, 06 Jan 2023 01:14:58 -0800 (PST) MIME-Version: 1.0 References: <20230105230725.2401243-1-moritzf@google.com> In-Reply-To: <20230105230725.2401243-1-moritzf@google.com> From: "Ard Biesheuvel" Date: Fri, 6 Jan 2023 10:14:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: devel@edk2.groups.io, moritzf@google.com Content-Type: text/plain; charset="UTF-8" On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io wrote: > > Linux' cpu DT bindings call out arm,armv8 while the code previously > used arm,arm-v8. > > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") > Signed-off-by: Moritz Fischer > --- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > index 2c72bd0c58..dc6e7a4d15 100644 > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > @@ -22,7 +22,7 @@ > */ > STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = { > { "arm,arm-v7" }, > - { "arm,arm-v8" }, > + { "arm,armv8" }, Thanks for the patch Should we keep both instead of removing the old one? > { "arm,cortex-a15" }, > { "arm,cortex-a7" }, > { "arm,cortex-a57" } > -- > 2.39.0.314.g84b9a713c41-goog > > > > > >