From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web10.39611.1629208941815165251
 for <devel@edk2.groups.io>;
 Tue, 17 Aug 2021 07:02:21 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HZSyA4r4;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A34B60232
	for <devel@edk2.groups.io>; Tue, 17 Aug 2021 14:02:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1629208941;
	bh=OJ7QaqM44+cUxNTxBcAhyizMb2NzjtPxhf2Oz++fjcQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=HZSyA4r4ZJOCu8w1UkVBxqEGJpX+hag58L5QdwFI8EurkQb62xEYPOBaf3cGamN7n
	 tm0MU1WXMeIj6K+KDOpUpkuB1ljxrYly+/QzndOkvYJMpZmQzUV3Gaj9XwoU+7ObqN
	 gbpF/hvZvWhrVJxQKpP4kLA63EhkDMnu6UEwzpAGeRYyKSponsWhgwv/c+YVxSZ/t5
	 XalbmAHUPO+17TTd8Lzv+CqNbHz5yQs+hDwQ0Yb6WOQbOjTE1p8ipdhaVoEfUQP8ee
	 1zsJ3KIjbqGEGisHVzQxu4hrsrgowtLbgJUuVhfoMouDkKGgN07L1qbKWK09ZSzLGN
	 ZNk8jnvsLGR6w==
Received: by mail-ot1-f46.google.com with SMTP id f16-20020a056830205000b00519b99d3dcbso4071260otp.2
        for <devel@edk2.groups.io>; Tue, 17 Aug 2021 07:02:21 -0700 (PDT)
X-Gm-Message-State: AOAM530sExN28C3EgSzCSwoo1s9qxJa6K3cnZCeOcAneQuRJ30nvvSdy
	LK5nNOwJeSG2F6TtqS2LTSfPE8YKzfdvto+xQVE=
X-Google-Smtp-Source: ABdhPJyFeWod8TN3A5hbvwhRwIoUwRW/+zljHYgjSDLUGE9dZIeIqn+EY+PAgphfc4Lgb6zd49g0YSu1eD+iX0CNwG8=
X-Received: by 2002:a05:6830:47:: with SMTP id d7mr2720980otp.108.1629208940584;
 Tue, 17 Aug 2021 07:02:20 -0700 (PDT)
MIME-Version: 1.0
References: <20210813050508.28232-1-jeremy.linton@arm.com> <CAMj1kXE+BUhOn0LANoUG9q3KZ8-aaJc7dOk-TVh3+zcgRcib-w@mail.gmail.com>
In-Reply-To: <CAMj1kXE+BUhOn0LANoUG9q3KZ8-aaJc7dOk-TVh3+zcgRcib-w@mail.gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 17 Aug 2021 16:02:09 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGasgZqevzLM_mVRceNG8JRm=dcFto5J5t=nuiBaiSarw@mail.gmail.com>
Message-ID: <CAMj1kXGasgZqevzLM_mVRceNG8JRm=dcFto5J5t=nuiBaiSarw@mail.gmail.com>
Subject: Re: [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field
To: Jeremy Linton <jeremy.linton@arm.com>, 
	"Liming Gao (Byosoft address)" <gaoliming@byosoft.com.cn>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Peter Batard <pete@akeo.ie>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Leif Lindholm <leif@nuviainc.com>, 
	Andrei Warkentin <awarkentin@vmware.com>, Sunny Wang <Sunny.Wang@arm.com>, 
	Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 16 Aug 2021 at 09:10, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Fri, 13 Aug 2021 at 07:05, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Map->Operation is used to select whether a DMA region that
> > is being bounced has the source buffer copied to it. Except
> > Map->Operation isn't yet set, so the behavior is somewhat
> > random. Instead use the passed in Operation parameter.
> >
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Thanks for fixing this.
>
> Liming, I am not sure what stage of the release cycle we are currently
> in, but this fix should go in right away anyway. Unless any objections
> are raised, I will merge it later today. I will leave it to you to
> decide how this affects the stable tag release schedule.
>

Merged as #1901