From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.46639.1675097684565310817 for ; Mon, 30 Jan 2023 08:54:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f0ztN49X; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F6B8B8136F for ; Mon, 30 Jan 2023 16:54:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A1DCC4339E for ; Mon, 30 Jan 2023 16:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675097681; bh=kB1E76Yp638QzrDETYgPBuMGqwVO0Lyjuax74h3V6FI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f0ztN49Xveh2CHdOEjDsPaZtu53lEgABZJ5ty1tCpVT3PfraJKYU+EVDh+1kk1vQH qe17pHVHTI2/R2BzUF98bK5cIyx8OszjpqDh06ZeBP9ym6yP/dkMd4jo1KKL1JI9N8 slDansHViVNSsCMQ5SwjEm7M9HyQkRk7gOG8Ihb3LcwzgL6IDwjbauRY1vZOk+OyQh Jn+zCGDIwJIiaH8qLX4AnuJu49lk8QLSUzhVZpZjUoguf6hvQfMxw2KwoJXB3ZRoii Z3ZF+5WqT3n0i7M+vXUk4ttH3e3S8UvBER1QPnCLU5lhjvkfz84fyVeEMJ4woiMWbD 2B4OENd5Hrc9Q== Received: by mail-lf1-f50.google.com with SMTP id br9so19982424lfb.4 for ; Mon, 30 Jan 2023 08:54:41 -0800 (PST) X-Gm-Message-State: AFqh2ko5zmJJKIhj1wq1dM+QY+0FKsKYV7UeZRTNMVG0CZMmlBXxCMjx 22KEzcNwbZU2Ifq9Db5BWbWTUicLuvHKqIP7aDc= X-Google-Smtp-Source: AMrXdXsjWokzf1lFG+8j4efhQry/P9c4K/2j8V0lpQBqjge6XATHntQHplZlEZEOGb9Fw342iy586XZ7zsKF8ebW2+Y= X-Received: by 2002:a05:6512:2525:b0:4b6:fae9:c9b9 with SMTP id be37-20020a056512252500b004b6fae9c9b9mr4560454lfb.207.1675097679157; Mon, 30 Jan 2023 08:54:39 -0800 (PST) MIME-Version: 1.0 References: <20230127192116.3577219-1-dionnaglaze@google.com> <011701d933a0$cd86fca0$6894f5e0$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 30 Jan 2023 17:54:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Gao, Liming" , Dionna Amalie Glaze , "Xu, Min M" , "Yao, Jiewen" , "Liu, Zhiguang" , "Wang, Jian J" Content-Type: text/plain; charset="UTF-8" On Mon, 30 Jan 2023 at 17:27, Kinney, Michael D wrote: > > Hi Ard, > > Can you explain the process being followed here for content like this. > > The EDK II Code First Process as detailed below requires all content to only > be added to edk2-staging repo and used from there before spec changes become > public. Content is only added to the edk2 repo until after the spec with the > change is public. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process > > This process was reviewed and approved by the community. If there is a need > for an alternate process, then that needs to be proposed, reviewed, and accepted. > Hello Mike, I was not involved at all in the creation of these definitions. This patch merely fixes the wrong index value that was introduced by commit 502c01c5028038e4e6b4512e9c66be0ec4d11492 Author: Min M Xu Date: Tue Nov 1 13:13:43 2022 +0800 MdePkg: Add UEFI Unaccepted memory definition RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 Plase refer to: UEFI Spec v2.9 Table 7-5 Memory Type Usage before ExitBootServices() Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Reviewed-by: Jiewen Yao Acked-by: Gerd Hoffmann Reviewed-by: Liming Gao Signed-off-by: Min Xu