From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.17839.1664796228109964273 for ; Mon, 03 Oct 2022 04:23:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eCw37VZB; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58A4D61035 for ; Mon, 3 Oct 2022 11:23:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 347B1C43141 for ; Mon, 3 Oct 2022 11:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664796226; bh=s74QeLKofspvFSlWwp82i//ARtLB83dG2Mvj6orBJCo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eCw37VZBEsYZjY4LG1DEq/z/RrZuJ0duyVHbqUl0RgBhhlt8SiJPZG9bd25K/8EZj yjV2GM6IOiSCI4XcQuhWudoErSBEY2K8JMFD69AbVKWu92ZcspVUM5Qi34nGcDW6Ng 4+0KQ0aJQj6ekFn1ntzzQpLkxE4xi5K2HaQVAuXO8ZMEiSUJOG22NhO/quw2jPyz6Y QqZaCJW08wbWcw8W41d42sRKfSkdkOJ5NTmO83BZDxOSd2K/P8T3D8XKwCyrYqTNRH m/UXjPMlCMuvNTBBh7tNE3t3PdiykVFIXPAJT4SroFhNoFfEfuPeHcliOR27/ivI6z 1sh7vJF0pNuiA== Received: by mail-lf1-f51.google.com with SMTP id 25so5832150lft.9 for ; Mon, 03 Oct 2022 04:23:46 -0700 (PDT) X-Gm-Message-State: ACrzQf0OhyIp9Nw99ldEAQPWfU/IM2/GyCSIe/I3omRd7yHqBm2EVHIZ 4Ui3vHdrGr28DoTpt39AJM6fjWYcLuNbArrARk4= X-Google-Smtp-Source: AMsMyM6K2ocmOey6S43clxnZYTCSpXruMFaDPfchB8S4FcxHCnDoYDk5JjedInnCSlSpEqjU85ofYdq1Osik93OCI7E= X-Received: by 2002:a05:6512:261b:b0:4a1:abd7:3129 with SMTP id bt27-20020a056512261b00b004a1abd73129mr7547136lfb.637.1664796224188; Mon, 03 Oct 2022 04:23:44 -0700 (PDT) MIME-Version: 1.0 References: <20220930230627.3371754-1-dionnaglaze@google.com> <20220930230627.3371754-3-dionnaglaze@google.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 3 Oct 2022 13:23:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v5 2/7] MdePkg: Introduce ExitBootServicesCallbackProtocol To: Dionna Amalie Glaze Cc: "Ni, Ray" , "devel@edk2.groups.io" , Gerd Hoffmann , "Xu, Min M" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Andrew Fish , "Kinney, Michael D" Content-Type: text/plain; charset="UTF-8" On Mon, 3 Oct 2022 at 03:16, Dionna Amalie Glaze wrote: > > > > > Is it defined by UEFI Spec? > > > > It is not. This is Ard's suggested solution > https://patchew.org/EDK2/20220928153323.2583389-1-dionnaglaze@google.com/20220928153323.2583389-5-dionnaglaze@google.com/#CAMj1kXFwbU9oiULUFXSrqhag1Pf+YU2dL4JbUZ2LO0k9uUEqRg@mail.gmail.com > It is not in the spec, which is why we called it gEdkiiExitBootServicesCallbackProtocolGuid What Ray is getting to (I think) is that that means that it should be defined in MdeModulePkg not MdePkg.