Re: [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 5 Mar 2024 at 12:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
>   build -a AARCH64 -b DEBUG \
>     -m ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf \
>     -p ArmVirtPkg/ArmVirtKvmTool.dsc -t GCC5
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
>  ArmVirtPkg/PrePi/PrePi.c                            | 6 ------
>  2 files changed, 1 insertion(+), 7 deletions(-)
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


> diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> index 6b9244bd1a6b..578ee37e7467 100755
> --- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> +++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> @@ -8,7 +8,7 @@
>  #**/
>
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = ArmVirtPrePiUniCoreRelocatable
>    FILE_GUID                      = f7d9fd14-9335-4389-80c5-334d6abfcced
>    MODULE_TYPE                    = SEC
> diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c
> index ff51a757a21a..f27e0ad3d223 100755
> --- a/ArmVirtPkg/PrePi/PrePi.c
> +++ b/ArmVirtPkg/PrePi/PrePi.c
> @@ -22,12 +22,6 @@
>
>  #include "PrePi.h"
>
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> -  VOID
> -  );
> -
>  VOID
>  PrePiMain (
>    IN  UINTN   UefiMemoryBase,
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116388): https://edk2.groups.io/g/devel/message/116388
Mute This Topic: https://groups.io/mt/104742526/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-