Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 20 Jun 2024 at 16:33, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> Related to https://github.com/tianocore/edk2/pull/5797
>
> PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
> Its functionality has been partially broken, and mostly ignored, for
> all AArch64 platforms since December 2020.
>
> This set cleans up some broken line endings in .dsc* files, then
> drops all non-invasive references to the Pcd:
> - .dsc* files setting it to 0 (which is the default in the definition,
>   and means "just read it from the system register instead")
> - .inf files declaring a dependency that is in fact not there in
>   current code.
>
> Finally, it drops the setting of the Pcd for platforms that set it to
> non-0. This has *never* done the right thing on these platforms since
> they are all AArch64, but it may affect timer timeout, so deserves
> deeper testing.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Narinder Dhillon <ndhillon@marvell.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>
> Leif Lindholm (5):
>   Platform/SbsaQemu: fix .dsc line endings
>   Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
>   Platform/ARM: drop use of PcdArmArchTimerFreqInHz
>   Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
>   Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz
>

Looks fine to me

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119660): https://edk2.groups.io/g/devel/message/119660
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-