From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A363B740034 for ; Thu, 20 Jun 2024 14:43:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=P4t8OXW+2gK8HuumAfB1i4IY3STVGFkzwYO3rniq5uY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1718894602; v=1; b=lWgr5CPJUZVAWVd9NVWIunYvuAkHZRqPHnxjUT3vQoggYV9ovpcMaGiIHQ2kBmdvbHS/xBwu 7MwNtIUQ/8w91iJZ2GIBHfcrsKpvO9i28gG7jvztrNqPL3XF13KHtgM8xrLurkBqpDEvNguyLUk tLGoq7PArJyklFu7M89DAZOSqaQ5d2/ISx+n88J5jJlc18RqwtfjvoB8C9f2Z0BYeYrHB61+zvB P/xEXfe71TtL8BJZeICKomD/RVTuvSiqXQAv0ccdEBHfKAwyoCETJ8QMZXGKRMt+dAPG5qPTzb5 tvQZfjbAv4Nf80Hr7hEa+9x7xUWUCFl5PzvcUX8ybuaqg== X-Received: by 127.0.0.2 with SMTP id ShvZYY7687511xPNd9Pgckw4; Thu, 20 Jun 2024 07:43:21 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.49254.1718894599929740575 for ; Thu, 20 Jun 2024 07:43:20 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 402F1CE26C6 for ; Thu, 20 Jun 2024 14:43:16 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69161C4AF11 for ; Thu, 20 Jun 2024 14:43:13 +0000 (UTC) X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52bc121fb1eso1066629e87.1 for ; Thu, 20 Jun 2024 07:43:13 -0700 (PDT) X-Gm-Message-State: IIqJZMVwdo1d0Kn5cU1K65SXx7686176AA= X-Google-Smtp-Source: AGHT+IHbibE4mzL9xzY+bOkxDUQ1pp3MbRbssz+p/F2qozhnqitbiU94iG27CojkJgoXJl/YCWrKc25uo3aJUn6H5qU= X-Received: by 2002:a19:2d54:0:b0:52c:c555:6b39 with SMTP id 2adb3069b0e04-52ccaa33f2cmr3528747e87.16.1718894591715; Thu, 20 Jun 2024 07:43:11 -0700 (PDT) MIME-Version: 1.0 References: <20240620143243.460947-1-quic_llindhol@quicinc.com> In-Reply-To: <20240620143243.460947-1-quic_llindhol@quicinc.com> From: "Ard Biesheuvel" Date: Thu, 20 Jun 2024 16:43:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Ard Biesheuvel , Chuong Tran , Graeme Gregory , Marcin Juszkiewicz , Marcin Wojtas , Meenakshi Aggarwal , Narinder Dhillon , Nhi Pham , Rebecca Cran , Sami Mujawar , Thomas Abraham , Wenyi Xie Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 20 Jun 2024 07:43:20 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lWgr5CPJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 20 Jun 2024 at 16:33, Leif Lindholm wrote: > > Related to https://github.com/tianocore/edk2/pull/5797 > > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. > Its functionality has been partially broken, and mostly ignored, for > all AArch64 platforms since December 2020. > > This set cleans up some broken line endings in .dsc* files, then > drops all non-invasive references to the Pcd: > - .dsc* files setting it to 0 (which is the default in the definition, > and means "just read it from the system register instead") > - .inf files declaring a dependency that is in fact not there in > current code. > > Finally, it drops the setting of the Pcd for platforms that set it to > non-0. This has *never* done the right thing on these platforms since > they are all AArch64, but it may affect timer timeout, so deserves > deeper testing. > > Cc: Ard Biesheuvel > Cc: Chuong Tran > Cc: Graeme Gregory > Cc: Marcin Juszkiewicz > Cc: Marcin Wojtas > Cc: Meenakshi Aggarwal > Cc: Narinder Dhillon > Cc: Nhi Pham > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Wenyi Xie > > Leif Lindholm (5): > Platform/SbsaQemu: fix .dsc line endings > Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz > Platform/ARM: drop use of PcdArmArchTimerFreqInHz > Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz > Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz > Looks fine to me Reviewed-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119660): https://edk2.groups.io/g/devel/message/119660 Mute This Topic: https://groups.io/mt/106780872/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-