From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.38205.1679475901892239407 for ; Wed, 22 Mar 2023 02:05:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQ2+yr+Z; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2940D61F39 for ; Wed, 22 Mar 2023 09:05:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E97BC4339B for ; Wed, 22 Mar 2023 09:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679475900; bh=Ea0rf1eXb1QLHDA0/4njhSPVOQBwU45JgSTuDYXJoUA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RQ2+yr+Zk/GPFPYhbnLKHyi6phFvGv/5rbipO5SgLbo4EAvgDFLf6zF6sQl4cJKI6 sDN5lJsJCprLgSf/6Bvh+RUdvrHIS2j2boqRezaG75OxJDJ2E/tA22XemXEcJYunnc VYK/Ff9QlB0u+KPQzxS+0yboCSZlSls1l525VVr9NHFAVZ2sv0OObZGxrComdzeO04 5+oGf/W+JQ4kMlPD/zbWkEUwFqJhqHG5T+CoZ6DKDrS2l4RiVdpfdkX5YGjx5jhMwF HI20axqXH4AhOe4fhFslSCx0H/PF88oANLcgdJQWZUcGGpr/BS+y5a6sIDM4ZuGhN6 +Ck1Qn/cedFOw== Received: by mail-lf1-f41.google.com with SMTP id bi9so22387133lfb.12 for ; Wed, 22 Mar 2023 02:05:00 -0700 (PDT) X-Gm-Message-State: AAQBX9erYWsF6XSnnmLfJljjEpJ8egaokpFhgY8nE+J7AnKIvApqystX zGHD4LwpqgSwmvm6g+x5uyA5aqqlHQPwP2+GJ8c= X-Google-Smtp-Source: AK7set9N6vkIfO9JWLxNF5mSM9XQo3rC3rwp93nMPP/yrnCCpOstYF9It4qp6lZbMKNkpQJeLcTLX7GFjSnaCMTVeWo= X-Received: by 2002:ac2:53a9:0:b0:4ea:12f7:a725 with SMTP id j9-20020ac253a9000000b004ea12f7a725mr1705375lfh.4.1679475898517; Wed, 22 Mar 2023 02:04:58 -0700 (PDT) MIME-Version: 1.0 References: <20230322013040.3322865-1-rebecca@bsdio.com> In-Reply-To: <20230322013040.3322865-1-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Wed, 22 Mar 2023 10:04:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/9] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38 and update CLANGDWARF, delete VS 2008-2013, EBC To: Rebecca Cran Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Ard Biesheuvel , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Hello Rebecc, Thanks for working on this - the toolchain definitions are not the most fun part of the project. On Wed, 22 Mar 2023 at 02:30, Rebecca Cran wrote: > > Update the toolchain definitions: > > - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with > CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 > and IA32. > > - Remove VS2008, VS2010, VS2012 and VS2013. > > - Remove EBC compiler definitions. Full removal of EBC support from the > various packages etc. will be done in a follow-up patch series. > > - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions. > Please add some motivation as to *why* these changes improve upon the current situation. Removing stuff is generally a good thing, but it makes a difference whether keeping it is problematic or it whether is just janitorial work. > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4158 > GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf > > Rebecca Cran (9): > OvmfPkg: Replace static struct initialization with ZeroMem call > CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler > flags > BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 > BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions > BaseTools: Remove VS2008-VS2013 remnants > MdePkg: Remove VS2008-VS2013 remnants > edksetup.bat: Remove VS2008-VS2013 remnants > BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs > BaseTools: Remove EBC (EFI Byte Code) compiler definitions > > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 3 +- > MdePkg/Include/Ia32/ProcessorBind.h | 8 +- > MdePkg/Include/X64/ProcessorBind.h | 8 +- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +- > BaseTools/Conf/tools_def.template | 1572 +++----------------- > BaseTools/Scripts/SetVisualStudio.bat | 22 +- > BaseTools/Scripts/ShowEnvironment.bat | 44 - > BaseTools/get_vsvars.bat | 13 - > BaseTools/set_vsprefix_envs.bat | 64 - > BaseTools/toolsetup.bat | 24 +- > edksetup.bat | 6 +- > 21 files changed, 192 insertions(+), 1606 deletions(-) > > -- > 2.34.1 >