From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.8925.1662564092354059294 for ; Wed, 07 Sep 2022 08:21:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DVJXQnfI; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 74CBB61828 for ; Wed, 7 Sep 2022 15:21:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEB09C433B5 for ; Wed, 7 Sep 2022 15:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662564090; bh=rsGho9+KFYXvDdxFDhmrAV5IByH6mk2mU/0oNs7mRMQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DVJXQnfIDIK+/MN4YhYNk50rLlYTea1AEAmM1O4IDR8RZw6w+PbetiXIE58HALeO0 s+27CmT2Pne5i2U7kTJmNYkSXzHPWtbY0gXX1bvNMnRypLbXhfI04feJ8ZpVYEYEkH GIARjPzhlY175PzPvWaRlbSSOlSDsWnhui196FeeWjFF8FMJAveP1G3/IjUXJqMEfP khq+ZhRUTtpSkUVDY6Cc+IgNhs/w1aUVn68azkRdsbnzr0AfZLFVzOj3s3v1lP88SW kmkxSM/8wITAGVY0WakBEymJbnqkJ0W9MQTk+6lGY3MOh3FbDOGuXNV50j7O0qLgMA yY30gDTMtMMJg== Received: by mail-lf1-f45.google.com with SMTP id k10so8373244lfm.4 for ; Wed, 07 Sep 2022 08:21:30 -0700 (PDT) X-Gm-Message-State: ACgBeo0N0ZUECrLOpguczNEkwDzdpxhnjslaB8+Mt5toP3yaOahR01Fh Rm5YxNTFwctf5Atw/CXaCQAX6tW6GDQHxYDhTH4= X-Google-Smtp-Source: AA6agR5z0fsj3aVbvwwm9lo9xS43R5PZ95NgD/CREpjrzCqO+/Ga7MSzCWce4EfyKEgswH1u2yJGOVLMDNiNDtKOLcw= X-Received: by 2002:a05:6512:3d09:b0:497:ab35:fd12 with SMTP id d9-20020a0565123d0900b00497ab35fd12mr678444lfv.539.1662564088921; Wed, 07 Sep 2022 08:21:28 -0700 (PDT) MIME-Version: 1.0 References: <20220907040326.388003-1-rebecca@quicinc.com> <20220907040326.388003-2-rebecca@quicinc.com> <1712796FB27A1CB6.17907@groups.io> <817ece1b-ab1d-7639-093d-de40867ea1b8@quicinc.com> <628d9f35-4b7a-2b12-71c1-9bcd5920ca76@linux.microsoft.com> In-Reply-To: <628d9f35-4b7a-2b12-71c1-9bcd5920ca76@linux.microsoft.com> From: "Ard Biesheuvel" Date: Wed, 7 Sep 2022 17:21:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: quic_rcran@quicinc.com, quic_llindhol@quicinc.com, Michael Kinney , Andrew Fish , Sami Mujawar , Jian J Wang , Liming Gao Content-Type: text/plain; charset="UTF-8" On Wed, 7 Sept 2022 at 17:11, Michael Kubacki wrote: > > Maintainers have two options for Spell Check as described in the Spell > Check CI Plugin readme - > https://github.com/tianocore/edk2/tree/master/.pytool/Plugin/SpellCheck > > 1. Set AuditOnly to "true" - Disables all spelling errors in the package > from the failing the build entirely. > > 2. Extend the dictionary - Add specific words that are allowed. Many > packages already do this. > > 3. IgnoreStandardPaths - Do not check files by path pattern. > > As a maintainer, you can either opt out of Spell Check from the failing > the build entirely by enabling AuditOnly or choose a different level of > granularity by simply updating your package CI YAML file. > Thanks for the explanation - patch coming up. > On 9/7/2022 3:35 AM, Ard Biesheuvel wrote: > > On Wed, 7 Sept 2022 at 06:35, Rebecca Cran wrote: > >> > >> Also, CI is failing in the SpellCheck test because of the > >> "-mstrict-align" in > >> ArmPsciMpServicesDxe.inf. > >> > >> /home/vsts/work/1/s/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf:55:25 > >> - Unknown word (mstrict) > >> > >> Should I add "mstrict" to pytool/Plugin/SpellCheck/cspell.base.yaml ? > >> > > > > This is getting ridiculous. > > > > I'm all for code quality and automation, but if t we cannot use > > compiler command line options that it supported since the dawn of time > > without bending over backwards to placate the CI machine, we are > > throwing out the baby with the bath water. > > > > At the very least, maintainers should be able to override the CI - I > > spent 2 hours yesterday preparing a submission that ultimately got > > rejected because MPIDR is not in the permitted word list (suggestion: > > use 'mpidr') > > > > In the Linux kernel, we have patch check and sparse (which is somewhat > > similar to ECC in a sense). Some maintainers run it, some don't, but > > in the end, the discretion lies with the person not the machine. This > > is the only way that makes sense. > > > > As the co-maintainer of ArmPkg, ArmVirtPkg, ArmPlatformPkg, OvmfPkg > > and EmbeddedPkg, I hereby request that the Ci restrictions are either > > lifted entirely for these packages, or relaxed so that a PR can be > > merged at my discretion, even if the CI thinks there are unresolved > > issues. > > > > > > > >> On 9/6/22 22:25, Rebecca Cran wrote: > >>> On 9/6/22 22:03, Rebecca Cran wrote: > >>>> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > >>>> index 59fd8f295d4f..4716789402fc 100644 > >>>> --- a/ArmPkg/ArmPkg.dsc > >>>> +++ b/ArmPkg/ArmPkg.dsc > >>>> @@ -125,6 +125,7 @@ [Components.common] > >>>> ArmPkg/Drivers/CpuPei/CpuPei.inf > >>>> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > >>>> ArmPkg/Drivers/ArmGic/ArmGicLib.inf > >>>> + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > >>>> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf > >>>> ArmPkg/Drivers/TimerDxe/TimerDxe.inf > >>> This won't work, since there's no support for 32-bit ARM code. > >>> I'll move it into the AARCH64 section. > >>> > >> > >> > >> > >> > >> > >> > > > > > > > > > > > > >