Re: [edk2-devel] [PATCH v2] add ArmCpuInfo EFI application

["Ard Biesheuvel" <ardb@kernel.org>]

On Fri, 7 Apr 2023 at 14:46, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> W dniu 7.04.2023 o 12:55, Ard Biesheuvel pisze:
> > Hello Marcin,
> >
> > Thanks for this - it looks useful.
>  > Some comments below.
>
> Thanks.
> > On Fri, 7 Apr 2023 at 12:40, Marcin Juszkiewicz
> > <marcin.juszkiewicz@linaro.org> wrote:
> >>
...
> >> +        char* description;
> >> +        char* bits;
> >
> > CONST
>
> It is not const.
>

The pointer is not const but the string is

const char *bits;

allows you to make 'bits' point to different constant string literals.


char *bits;

is only needed if you are pointing 'bits' at a string and subsequently
modify the /contents/ of the string, but i don't thank that is what
you are doing here.


> >> +
> >> +
> >> +        bits = "3:0 ";
> >> +        value = aa64mmfr0_el1 & 0xf;
> >> +        switch(value)
> >
> > Space after switch
>
> done
>
> >> +        if(value == 0b0110)
> >
> > Space after if
>
> done
>
> > etc etc
> >
> > There are some other style issues here, which I am sure the CI will
> > whine about, so you might want to run uncrustify on it.
>
> done
>