From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.7533.1627553693622174582 for ; Thu, 29 Jul 2021 03:14:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cT+Gv5Xg; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0713761040 for ; Thu, 29 Jul 2021 10:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627553693; bh=dvgRIJo6seXEGHs39sjuCc7NYJKB02U5t1NHtupS9xw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cT+Gv5XgerAfuff113wR4y02SonXySaf2FTFTByERETLHcl4ZGCb/AtjgA09zdbkW jq7pDPDrfXZWP+uozM9PSMCuQw2JDeSqfEqz1YUwxMMD5G9dx7bVVjWNMROso2uIGp O6NrYz/Cxd7D4LTGY2wZ6IelpF/GrxcCacht7t2shI6BglN57RDrs6Ky1aXCCzUY8f +xELYevUvMztGhPGrrZJllCvHiUs+YPKu6Ky6WRHSGYFVnwpE4RPwuGSp3be/51K5c Q42y3Hy2Be9arkt7BBHGNF4fn/Jd0xI2jgSwYzUMEXX/1mdOry50ngvqsKSUyZ8Oo9 BGz8nF5ByycvA== Received: by mail-oi1-f174.google.com with SMTP id t128so7842882oig.1 for ; Thu, 29 Jul 2021 03:14:52 -0700 (PDT) X-Gm-Message-State: AOAM531KEvfha2spwqUkxQOVzyLebQG1eCHvutRMNS7/pfvZY1qvKjjS 93b+wq0MhtLZEvTwnphjdtkhwQSTKX984RCcYe0= X-Google-Smtp-Source: ABdhPJxl0xUG9WcwduLuwRw+8IP/yEq+SQmYoQb7Zo3ZaIzVZJ5mPnTpfgj8H4epcjWQCRF/9ijRJV2Z+uADUMIw2ds= X-Received: by 2002:aca:d64d:: with SMTP id n74mr9617794oig.47.1627553692368; Thu, 29 Jul 2021 03:14:52 -0700 (PDT) MIME-Version: 1.0 References: <20210721081843.32164-1-philmd@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 29 Jul 2021 12:14:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment To: Sami Mujawar Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "devel@edk2.groups.io" , Laszlo Ersek , Ard Biesheuvel , Leif Lindholm , Julien Grall , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 21 Jul 2021 at 10:24, Sami Mujawar wrote: > > Hi Philippe, > > Thank you for this patch. > > Reviewed-by: Sami Mujawar > Merged, thanks. > Regards, > > Sami Mujawar > > =EF=BB=BFOn 21/07/2021, 09:19, "Philippe Mathieu-Daud=C3=A9" wrote: > > From: Philippe Mathieu-Daude > > The "Shell Embedded Boot Loader" description (added in > commit 6f5872b1f401) does not add any value, remove it. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Julien Grall > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > ArmVirtPkg/ArmVirt.dsc.inc | 3 --- > ArmVirtPkg/ArmVirtKvmTool.fdf | 3 --- > ArmVirtPkg/ArmVirtXen.fdf | 3 --- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 --- > 4 files changed, 12 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index d9abadbe708c..619b5f0b44c0 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -375,9 +375,6 @@ [Components.common] > # > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > - # > - # UEFI application (Shell Embedded Boot Loader) > - # > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf = { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmToo= l.fdf > index 076155199905..152453dc4bb3 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.fdf > +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf > @@ -173,9 +173,6 @@ [FV.FvMain] > INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > > - # > - # UEFI application (Shell Embedded Boot Loader) > - # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.= inf > > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index 8fbbc2313aff..9597465cf58a 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -177,9 +177,6 @@ [FV.FvMain] > INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/Englis= hDxe.inf > INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > - # > - # UEFI application (Shell Embedded Boot Loader) > - # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.= inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.= inf > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVir= tQemuFvMain.fdf.inc > index 5b1d10057545..26f13f6a2115 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -99,9 +99,6 @@ [FV.FvMain] > INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > > - # > - # UEFI application (Shell Embedded Boot Loader) > - # > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.= inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.= inf > -- > 2.31.1 > >