From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Andrew Fish <afish@apple.com>,
edk2-devel-groups-io <devel@edk2.groups.io>,
"Loh, Tien Hock" <tien.hock.loh@intel.com>,
"thloh85@gmail.com" <thloh85@gmail.com>,
Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH V5 1/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver
Date: Wed, 28 Apr 2021 15:03:51 +0200 [thread overview]
Message-ID: <CAMj1kXGfBR9m7cJqvVFJOH0vaqcEWX88515fEx0=m63tSyw_Kg@mail.gmail.com> (raw)
In-Reply-To: <CO1PR11MB49298B2FB0B0B245630D8153D2419@CO1PR11MB4929.namprd11.prod.outlook.com>
On Tue, 27 Apr 2021 at 21:31, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> This is an example of another approach. This module uses PCI I/O or IoLib based on the type of device.
>
>
>
> https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Bus/Pci/PciSioSerialDxe
>
>
>
> No additional protocols or lib classes/instances. Instead, the register access APIs are included in the module and based on the type of device detected, it uses PCI I/O or IoLib:
>
>
>
> https://github.com/tianocore/edk2/blob/5b90b8abb4049e2d98040f548ad23b6ab22d5d19/MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c#L1327
>
> https://github.com/tianocore/edk2/blob/5b90b8abb4049e2d98040f548ad23b6ab22d5d19/MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c#L1358
>
>
>
> This technique could for PCI I/O vs MMIO register access. You would need to add more APIs for the use of PCI I/O or DmaLib for DMA access.
>
Is it really worth the effort to rewrite this code?
This patch has been circulating for a while now, and I fail to see the
point of refactoring and splitting up this code, given how unlikely it
is that DesignWare will ever put a real PCI frontend on this IP. The
SD/MMC override protocol was intended for implementations that are
almost SDHCI compliant, but have some quirks that need to be worked
around.
next prev parent reply other threads:[~2021-04-28 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210322032439.9312-1-tien.hock.loh@intel.com>
2021-03-22 3:24 ` [PATCH V5 1/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver Loh, Tien Hock
2021-03-30 4:36 ` Loh, Tien Hock
2021-04-16 5:34 ` Loh, Tien Hock
2021-04-26 17:53 ` Michael D Kinney
2021-04-27 9:08 ` Loh, Tien Hock
2021-04-27 10:27 ` Loh, Tien Hock
2021-04-27 17:31 ` [edk2-devel] " Andrew Fish
2021-04-27 19:31 ` Michael D Kinney
2021-04-28 13:03 ` Ard Biesheuvel [this message]
2021-04-28 14:58 ` Andrew Fish
2021-04-29 0:33 ` Loh, Tien Hock
2021-04-27 21:40 ` Michael Brown
2021-04-27 23:45 ` Andrew Fish
2021-04-28 0:06 ` Michael D Kinney
2021-04-28 0:52 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGfBR9m7cJqvVFJOH0vaqcEWX88515fEx0=m63tSyw_Kg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox