From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.26310.1685610464855923863 for ; Thu, 01 Jun 2023 02:07:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PB0Pui3b; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 50A976420C for ; Thu, 1 Jun 2023 09:07:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BF81C433A1 for ; Thu, 1 Jun 2023 09:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685610463; bh=p0H3BTp2Oo5Q3UP1QU5arUM3oTqofgXZ5TKTIYZLKZ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PB0Pui3bZnAopLC+yROWJKwBJgPk4ZMnkTW0Aqa0OL/Jxd3VKaSlWDNq/+w+wGAFK b7WUz6OnbnXU264m/Zw4WlIQ5QpWaUAOvjc03lyYChpCFMv4aAjcq5EMJJm8MiaZcP Un5LRK9csSkEeKrVuqXZfwIEmhH/DqIMBBgThyNAqAliL34Al4xTPtco3OFQ5RjAyA KqSwJiAeoXbZ+kTJsuEeY6mT9dsE8bJVbiZxro0aj2KR5MxvGsG8e14/hAnda/A4m/ pTvBtZ6Nh23koYvwd6EY+rnsGhy6qeUdcMLAiFrbbt6CCaXxJgU6ByIlTphHvDpnyz lm6Ujs+Js/LMA== Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2b1a66e71f9so1096881fa.2 for ; Thu, 01 Jun 2023 02:07:43 -0700 (PDT) X-Gm-Message-State: AC+VfDyb90/TDWFlWAsdqml9b9XfPH4elpgceaT1mHSBbpetvfDtK6mU uErMSsY7hOIRdXZfYmPsqr2LjRsqY8+8+0K1PgM= X-Google-Smtp-Source: ACHHUZ4PWv64oO/u/wE5N3iJoiXBKG9ofWLSUdF4dbuBVlaCMNNBcSElnDMG2bAoYPcy1/KPrKjFK6I3jCm2RdKCplA= X-Received: by 2002:a2e:8505:0:b0:2a8:bc08:a9a3 with SMTP id j5-20020a2e8505000000b002a8bc08a9a3mr4628489lji.28.1685610461230; Thu, 01 Jun 2023 02:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20230512142306.1323983-1-kraxel@redhat.com> <20230512142306.1323983-6-kraxel@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 1 Jun 2023 11:07:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/5] OvmfPkg/VirtioSerialDxe: use TPL_NOTIFY To: Gerd Hoffmann Cc: devel@edk2.groups.io, Jiewen Yao , Jordan Justen , Leif Lindholm , Pawel Polawski , Sami Mujawar , Oliver Steffen , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Thu, 1 Jun 2023 at 09:56, Ard Biesheuvel wrote: > > On Fri, 12 May 2023 at 16:23, Gerd Hoffmann wrote: > > > > Apparently TPL_CALLBACK is too low, code runs into an ASSERT > > complaining the new TPL is lower than the old TPL. > > > > Signed-off-by: Gerd Hoffmann > > Acked-by: Ard Biesheuvel > > I'll take this as a separate fix. > Merged as #4461 > > --- > > OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c b/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c > > index 522b25e9698c..e4a58deff162 100644 > > --- a/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c > > +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c > > @@ -158,7 +158,7 @@ VirtioSerialIoWrite ( > > > > VirtioSerialRingClearTx (SerialIo->Dev, PortTx (SerialIo->PortId)); > > > > - OldTpl = gBS->RaiseTPL (TPL_CALLBACK); > > + OldTpl = gBS->RaiseTPL (TPL_NOTIFY); > > if (SerialIo->WriteOffset && > > (SerialIo->WriteOffset + *BufferSize > PORT_TX_BUFSIZE)) > > { > > @@ -201,7 +201,7 @@ VirtioSerialIoRead ( > > goto NoData; > > } > > > > - OldTpl = gBS->RaiseTPL (TPL_CALLBACK); > > + OldTpl = gBS->RaiseTPL (TPL_NOTIFY); > > if (SerialIo->WriteOffset) { > > DEBUG ((DEBUG_VERBOSE, "%a:%d: WriteFlush %d\n", __func__, __LINE__, SerialIo->WriteOffset)); > > VirtioSerialRingSendBuffer ( > > -- > > 2.40.1 > >