From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web09.6659.1668438625088451615
 for <devel@edk2.groups.io>;
 Mon, 14 Nov 2022 07:10:25 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PHW6DYpo;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id E305AB80FED
	for <devel@edk2.groups.io>; Mon, 14 Nov 2022 15:10:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 972B5C433B5
	for <devel@edk2.groups.io>; Mon, 14 Nov 2022 15:10:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1668438621;
	bh=faVTQutlbkoliOvVsWbyC4qben2nFhXYVOu+fQ8em3o=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=PHW6DYpo01oUe6mM3r1tUeQhyg4B9gqIskKOm0ofCk0Dqir6oHMjI7K+B40fzsBGm
	 3d11FJIANvvR16OgxAmRNLIV1qdY90QAqJDYnOADjLHqF/ePuNx5YN108juqqci3OK
	 g5uNOE0p40uEEWkwMPdPs84IpgXwMs4X4GU7kECPGD5ykKRkDKTrIUyq4Cl/g5CgQH
	 Q6NQOv/EzTN3h/u1O1E/3rmQKQbxt9QVGeEVlknbnc3DTIvqVjyV7riLHn+Ij11Ev1
	 bVUehD2xxZRESP1q4KAC+Nrbrutz2LN0PrL7c7uZq5FW6jBdnfI3wcWEvTjl8v70yX
	 X5WrXGRP5kAUw==
Received: by mail-lf1-f54.google.com with SMTP id r12so19775657lfp.1
        for <devel@edk2.groups.io>; Mon, 14 Nov 2022 07:10:21 -0800 (PST)
X-Gm-Message-State: ANoB5pkNcrMQ0vjDLciMdA3mktVEY9iwByLz+Pr8TPm2FFsLVNnfK0je
	UDb3TVbHDibCa4o6EkF/FH6fatI9T9YCIBQHqKU=
X-Google-Smtp-Source: AA0mqf6QtQM4ADr+KAP3yuzSgoRfxn2KoFmqTxOFjR/E0gpvAL33wsUIYX7PE8KkG9BCWHAtuI6dhcAjpZSkhsUrA3s=
X-Received: by 2002:a05:6512:138f:b0:4ab:534b:1b2c with SMTP id
 p15-20020a056512138f00b004ab534b1b2cmr4009707lfa.426.1668438619609; Mon, 14
 Nov 2022 07:10:19 -0800 (PST)
MIME-Version: 1.0
References: <20221114144347.1664317-1-Pierre.Gondois@arm.com>
In-Reply-To: <20221114144347.1664317-1-Pierre.Gondois@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 14 Nov 2022 16:10:08 +0100
X-Gmail-Original-Message-ID: <CAMj1kXGh8h8qwONy0_4Cikjg=bUhBEgrB5oJEiAKZOvqrmt=Yg@mail.gmail.com>
Message-ID: <CAMj1kXGh8h8qwONy0_4Cikjg=bUhBEgrB5oJEiAKZOvqrmt=Yg@mail.gmail.com>
Subject: Re: [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
To: Pierre.Gondois@arm.com
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Leif Lindholm <leif@nuviainc.com>, Sami Mujawar <sami.mujawar@arm.com>, 
	Liming Gao <gaoliming@byosoft.com.cn>
Content-Type: text/plain; charset="UTF-8"

On Mon, 14 Nov 2022 at 15:44, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
>
> GetArmTrngVersion() is used to check the presence of an Arm
> Trng. If not found, an ASSERT prevents from booting in DEBUG
> builds.
> Remove this ASSERT.
>
> Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

Liming: please merge this if you are ok with it, or I can merge it if
you prefer.

> ---
>  ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> index fdabc02cd39c..3278722320c8 100644
> --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
>
>    Status = GetArmTrngVersion (&MajorRev, &MinorRev);
>    if (RETURN_ERROR (Status)) {
> -    ASSERT_RETURN_ERROR (Status);
>      goto ErrorHandler;
>    }
>
> --
> 2.25.1
>