From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E83AC7803DB for ; Fri, 19 Apr 2024 14:11:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2dSXgbEjBmssyi+4MCKHiEVKyYgcubqJuHZNpco3cGk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713535915; v=1; b=VyAmJs38d4j9mE4UiIhhC6mjWmhYrPTsgII8+j2gZ8owJPvj9PVDrc9E/oafKZHX+qm0HvvW ExAOqn9PB2l387PsIhyrJ6jAjK/eMN/tPtPWiSmoIVEz1xoIrOrx/lKbIc+3QAb5tOi6AOTaLWH VOtlB/1g5MMNZ07MLZ+F4gUAI8dEQFvwFK+KKTZNpEIjauFSVnMP/uZfr8VPf0TiF9YgfY7TTAC leYSp8XIc7VEk60B4UgLrU199ofQ1DSm4nwQ69KpdZ8C1a3Dhaqu5E8iLnwutW7d0O+eOTMWqyA 4asDl4EaO5I/lYK15VJhh5KsSbGlWnHFxJNiOeeTb2gvQ== X-Received: by 127.0.0.2 with SMTP id nmvZYY7687511xjKRGs9tPNx; Fri, 19 Apr 2024 07:11:55 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.22214.1713535909207524673 for ; Fri, 19 Apr 2024 07:11:49 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9BA10CE1AD6 for ; Fri, 19 Apr 2024 14:11:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC68AC32782 for ; Fri, 19 Apr 2024 14:11:44 +0000 (UTC) X-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2dcc8d10d39so9838341fa.3 for ; Fri, 19 Apr 2024 07:11:44 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVAfSJ29TfA2cc1nnO96TyvWvxvuooJFvN1W0yDdjOEd8kY821aphlozzeF8gIS20d5TCjzDrRwYCWz3V8KC/LCzSMDFg== X-Gm-Message-State: LIeMuC1pfzowU9dBpHzAyyqnx7686176AA= X-Google-Smtp-Source: AGHT+IE0BMWnmBbli1/i2QOjlRQQEp3QfCW4o/4r5SB3WjULCEu278QGZk8mFeD7QZ3U11dDtSipLTU4wjrOXTlDe/U= X-Received: by 2002:a2e:740f:0:b0:2da:38f:b09c with SMTP id p15-20020a2e740f000000b002da038fb09cmr1372009ljc.18.1713535903199; Fri, 19 Apr 2024 07:11:43 -0700 (PDT) MIME-Version: 1.0 References: <92659123892c9fd43a623b5babb6d2e0ed1e6d7a.1713193283.git.thomas.lendacky@amd.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 19 Apr 2024 16:11:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files To: "Chang, Abner" Cc: "Xing, Eric" , "devel@edk2.groups.io" , "Zhai, MingXin (Duke)" , "Lendacky, Thomas" , "Yao, Ken" , "Roth, Michael" , "Attar, AbdulLateef (Abdul Lateef)" , Ard Biesheuvel , Gerd Hoffmann , Min Xu , Leif Lindholm Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 19 Apr 2024 07:11:49 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=VyAmJs38; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 19 Apr 2024 at 15:00, Chang, Abner wrote: > > [AMD Official Use Only - General] > > I guess my RB misled contributors thought the patch is good to merge. How= ever, I was thinking Eric's team should give the final RB after the validat= ion as they are the maintainers for the subordinate VanGoghBoard platform. = Suppose the impacted packages should be built successfully with the patches= applied, as this is considered the base requirement of the code change. Ne= vertheless, the special build sauce for VanGoghBoard may be not easy for co= ntributors to verify the build. > > Eric, I have few suggestions for this failure, for the short term, you ca= n commit another change to remove this change, as the build failure has imp= acts on our customer support. You can decide to recover this or not depends= on your business requirement. Keeping edk2-platforms synced with edk2 is already complicated enough. So I object to changes to retain compatibility with downstream forks of EDK2. Surely, you are not telling your customers to use EDK202208 with whatever the top-of-tree of edk2-platforms is at any given moment? In any case, if upstream edk2 is important to you, please fix the current situation in edk2 first. If it is not important to you, I don't see a reason to revert anything, and you can fix it in your downstream. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118029): https://edk2.groups.io/g/devel/message/118029 Mute This Topic: https://groups.io/mt/105537744/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-