From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web08.5115.1662536270286936761 for ; Wed, 07 Sep 2022 00:37:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bP1WSJty; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0041CCE19FA for ; Wed, 7 Sep 2022 07:37:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09FBFC433D6 for ; Wed, 7 Sep 2022 07:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662536265; bh=oyYm2xHuqVB2tRJhHVY+olzMsPz7fBwy4Dmv0Gnx7Dc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bP1WSJtyaGZ8RjHD0yHiesP4nBV+ZSqN8l58v3/fWD6wSuuoJNAKIe656ERRelsnq Ma6LvHviQ9kWh49jj7iOdfg+AkamSXHzUrXaBr3wkGZUJcVRg4yJ3p51NanubM0sYr ksIhSb+szW5xix3akIwjA2dTci6M6SL8FH0TLvXsrwhKqH5tDWJ/7jjof7zTl2Mxw2 iXVbd5/i249paI8B/X2R9gjbTpWULg3U95QNi/K5GiubMdP9sTKyAbON/8+z6Lj40u ip8fD0BOJimY87Ti+QkoPG25yLnr//NWMhbz6uAhPIw4NL8FMLgAe6gKH9x9oFc4Xj f/yOQOFPVSNMw== Received: by mail-lj1-f175.google.com with SMTP id p5so1907489ljc.13 for ; Wed, 07 Sep 2022 00:37:44 -0700 (PDT) X-Gm-Message-State: ACgBeo3/0GlPvTt4AEQiX9Pz/awpXqi7Csc9imV/YUHQTGNIidcUpS8i FPb+kBdfdxPH4qh+Q+PzDHeZck0jDj9UHfl9KJ4= X-Google-Smtp-Source: AA6agR7dAykjoD0Cz6Zrh+E+GqR5sn4m6XUNiXxSDrdQ36soMjrsBXOCKKc/xVMCb1uPxe7c7Yt2YW5SFM0bJazrzRY= X-Received: by 2002:a2e:9b0e:0:b0:268:cb68:575b with SMTP id u14-20020a2e9b0e000000b00268cb68575bmr633577lji.152.1662536263047; Wed, 07 Sep 2022 00:37:43 -0700 (PDT) MIME-Version: 1.0 References: <20220907023649.312-1-mikuback@linux.microsoft.com> In-Reply-To: <20220907023649.312-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Wed, 7 Sep 2022 09:37:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/3] EmbeddedPkg: Enable CI To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Content-Type: text/plain; charset="UTF-8" On Wed, 7 Sept 2022 at 04:37, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046 > > Adds EmbeddedPkg to edk2 CI. > > Due to a number of build errors (some intentional) such as > 'BUILD_EPOCH' only being defined for GCC in > VirtualRealTimeClockLib.inf, the package is only run on GCC > build agents. > > This still allows build to be verified and non-build CI checks > to be performed. > > In the edk2 PR for this change, you can see that the package only > runs on GCC and CI passes with this configuration. > > https://github.com/tianocore/edk2/pull/3299 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: Michael Kubacki > > Michael Kubacki (3): > EmbeddedPkg/AcpiLib: Fix code formatting errors > EmbeddedPkg: Add CI YAML file > EmbeddedPkg: Only run in CI for GCC5 > NAK until we have a discussion about strictness of CI and ways to permit manual override of merge time CI restrictions. > EmbeddedPkg/Library/AcpiLib/AcpiLib.c | 88 +++++++++---------- > .azurepipelines/templates/pr-gate-build-job.yml | 4 + > .pytool/CISettings.py | 1 + > EmbeddedPkg/EmbeddedPkg.ci.yaml | 89 ++++++++++++++++++++ > EmbeddedPkg/EmbeddedPkg.dec | 8 ++ > EmbeddedPkg/Include/Library/AcpiLib.h | 22 ++--- > 6 files changed, 158 insertions(+), 54 deletions(-) > create mode 100644 EmbeddedPkg/EmbeddedPkg.ci.yaml > > -- > 2.28.0.windows.1 >