From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.54900.1673530719397408339 for ; Thu, 12 Jan 2023 05:38:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bgLeYGM0; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B380B81E6F for ; Thu, 12 Jan 2023 13:38:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B30C433F0 for ; Thu, 12 Jan 2023 13:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673530714; bh=Ujwl9Hc6tknTDD7F57T5pg0a1fs+X2XfXuOw29EYKes=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bgLeYGM06IXIP1u3ChSi1d5FC0Bd6wsmYuSxGNMp8xdZH7r2ZjvQE/ynCP20ovUm9 prejNqHHRnKsF6Ie+bYKs8zkDb/hRtPITJ7qmt1Tpn+j5lbHE5fWzZMDYrm6PcX7Iv dotM9Bd8riJnrvrwdVaMYXFhIVnW7wi0kS9ny7q/1I3IU+OPbxTJdp5U/djgstO6Qm wD8AGPlJ0UGdBihuy/YTP2ufA5UKKNLbRbO3gSBsXZheM8DlEEoTBi5cCNv/0zn5hI XDgP3bARUKzCh+sPN84vWdTf7Dqx8aZ+1TXdg95b+oNKIrCQK1xNaz7IiTetKVLPDc jejJQyzyuUpCg== Received: by mail-lj1-f175.google.com with SMTP id y18so15828765ljk.11 for ; Thu, 12 Jan 2023 05:38:34 -0800 (PST) X-Gm-Message-State: AFqh2kpJM7mWgv3f0ApxvQmEcvY7kDE8/KOm84q/SI1XFXmYvYksiiAU a9ZZfwan+rB0s8++DwxdV+JQOEdxumnsVKLmqy4= X-Google-Smtp-Source: AMrXdXtk5ERHbLO/roRZbQye7y9T3ai+9asl60NNZRXhvmtVwhQOyMGV85aYF82kecj9slyyBZ5K0uJPXupXkHLZwMc= X-Received: by 2002:a2e:bd0c:0:b0:27f:bc58:3924 with SMTP id n12-20020a2ebd0c000000b0027fbc583924mr4896474ljq.352.1673530712321; Thu, 12 Jan 2023 05:38:32 -0800 (PST) MIME-Version: 1.0 References: <20221108164616.3251967-1-dionnaglaze@google.com> <20221108164616.3251967-4-dionnaglaze@google.com> <75ed5959-fbb2-3343-e7d7-dfa17b4a2615@redhat.com> In-Reply-To: <75ed5959-fbb2-3343-e7d7-dfa17b4a2615@redhat.com> From: "Ard Biesheuvel" Date: Thu, 12 Jan 2023 14:38:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices To: devel@edk2.groups.io, lersek@redhat.com Cc: dionnaglaze@google.com, Gerd Hoffmann , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Xu, Min M" , Andrew Fish , "Ni, Ray" , Moritz Fischer , "Kinney, Michael D" Content-Type: text/plain; charset="UTF-8" On Thu, 12 Jan 2023 at 13:24, Laszlo Ersek wrote: > > On 1/12/23 00:08, Dionna Glaze via groups.io wrote: > > On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D > > wrote: > >> > >> Hi Dionna, > >> > >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > >> > >> I think you are at step 13. If you have not done so already, please update the > >> commit messages with all the Reviewed-by and Acked-by tags and make sure your > >> branch is rebased against the latest edk2/master and update the PR with that > >> content and verify that all EDK II CI checks pass. > >> > >> At that point, it is the responsibility of the EDK II Maintainers to review > >> the final state of the PR and set the "push" label if everything looks correct. > >> > >> At this moment, we are in Soft Freeze and will be in Hard Freeze for the next > >> 2 weeks. If this is considered critical for the stable tag release, then > >> please send a request to Liming with justification for stable tag. Otherwise, > >> it will be merged after the stable tag release. > >> > >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > >> > >> Thanks, > >> > >> Mike > >> > > > > Hi Mike, my PR was closed without comment > > https://github.com/tianocore/edk2/pull/3623 so I rebased and created a > > new PR after the holidays and hard freeze. I hope this isn't > > considered bad practice https://github.com/tianocore/edk2/pull/3885 > > > > I closed the PR -- similarly to how I manually closed 400+ stale PRs > then -- because it was not a maintainer-submitted PR with the "push" > label set. In other words, it was just a personal build, for triggering > a CI run. > > And, in fact regardlessly of whether it was a "push"-labeled maintainer > PR or just a personal PR, the PR was almost two months old. Clearly > stale and abandoned -- per edk2 contribution workflow, anyway. > > Please excuse me for not explaining this in a comment on the PR, but (as > I said above) I closed 400+ stale PRs manually within 10-15 minutes on > the github.com WebUI. The necessary muscle memory training didn't allow > for individual comments. > > (I actually tried scripting the mass-closure at first, with the "gh" > utility, but something in the github.com data model was broken, and the > server wouldn't allow me to close those PRs with the utility, even > though I had authenticated the utility under my account, with a complete > set of scopes -- see my report at > .) > > Regarding your new PR: it's again good for a personal CI run only. If it > completes fine, please post the patches to the mailing list, using > git-send-email. > > (From browsing recent list traffic, it seems that your colleague Moritz > Fischer has posted patches like that to the list; > please consider consulting with Moritz regarding the git setup (SMTP > server etc) withing Google. Cc'ing Moritz now.) > > When sending the patches like that, please CC the maintainers and > reviewers that are supposed to review them. Once they are happy with the > series, one of them will submit a PR with them, and set the "push" label > on the PR. When the CI run succeeds, the mergify bot will merge *that* > PR automatically. > I think we were already way past this with Dionna's work - numerous iterations have been posted and discussed, and the merge of the final version was only deferred because of the soft freeze.