From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ECCF674003A for ; Mon, 28 Aug 2023 16:38:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=X9z5np1KTclxtECic9eATqhw41x8BLzkFiEoWzhfJGs=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693240729; v=1; b=rvCDE4hqUDJiSWoU2eFNdWNQ1z33LtC53s3LcvsLje+lm6DWZb9fIDedCGDRdQ/JKvqEjGAv H0RMHRoD+5uLYHlCUlfooy1QpuAim/GdZPioiywxR5P81Ajj+Y/ub8jSSdnh9z7Ax+xbuVNtZt5 lR58SvplsSPDmMt9eKS4bUxw= X-Received: by 127.0.0.2 with SMTP id 1nmyYY7687511x0pxxyluVkC; Mon, 28 Aug 2023 09:38:49 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.187.1693240728816466176 for ; Mon, 28 Aug 2023 09:38:49 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30E3264209 for ; Mon, 28 Aug 2023 16:38:48 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C727C43391 for ; Mon, 28 Aug 2023 16:38:47 +0000 (UTC) X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5007c8308c3so5383356e87.0 for ; Mon, 28 Aug 2023 09:38:46 -0700 (PDT) X-Gm-Message-State: jVZxmlYaaoJJwrspkjhlT40ox7686176AA= X-Google-Smtp-Source: AGHT+IFdHCfaQqKAq6oF5kxy74Q7p3b0mX4KDGf3Gwdra5quUDTBCgsCTsRHyJ2a86W11M+UNSnkXEl4VsdChdF2Lqo= X-Received: by 2002:a05:6512:34c3:b0:4f8:d385:41bd with SMTP id w3-20020a05651234c300b004f8d38541bdmr16724358lfr.8.1693240725087; Mon, 28 Aug 2023 09:38:45 -0700 (PDT) MIME-Version: 1.0 References: <177845D072580598.19347@groups.io> <177BEFB7EF58B50B.8497@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 28 Aug 2023 18:38:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs To: Taylor Beebe Cc: devel@edk2.groups.io, Andrew Fish , Ard Biesheuvel , Dandan Bi , Eric Dong , Gerd Hoffmann , Guo Dong , Gua Guo , James Lu , Jian J Wang , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Rahul Kumar , Ray Ni , Sami Mujawar , Sean Rhodes Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rvCDE4hq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I was hoping to get around to this before the end of the week (but I am not a MdeModulePkg maintainer) On Mon, 28 Aug 2023 at 18:27, Taylor Beebe wrote: > > Can I please get reviews/feedback on this patch series? > > On 8/16/23 11:14 AM, Taylor Beebe via groups.io wrote: > > Can I please get reviews/feedback on this patch series? > > > > On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote: > >> From: Taylor Beebe > >> > >> v4: > >> - Expose additional functions in the Library API > >> - Add NULL checks to library functions and return a > >> status where applicable. > >> > >> v3: > >> - Refactor patch series so the transition of logic from the DXE > >> MAT logic to the new library is more clear. > >> - Update function headers to improve clarity and follow EDK2 > >> standards. > >> - Add Create and Delete functions for Image Properties Records > >> and redirect some of the SMM and DXE MAT code to use these > >> functions. > >> - Update/Add DumpImageRecords() to print the image name and code > >> sections of each runtime image which will be put in the MAT. > >> The DXE and SMM MAT logic will now invoke the DumpImageRecords() > >> on DEBUG builds at the EndOfDxe event to install the MAT. > >> > >> v2: > >> - A one-line change in patch 3 was moved to patch 9 for correctness. > >> > >> Reference: https://github.com/tianocore/edk2/pull/4590 > >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4492 > >> > >> The UEFI and SMM MAT logic contains duplicate logic for manipulating > >> image > >> properties records which is used to track runtime images. > >> This patch series adds a new library, ImagePropertiesRecordLib, > >> which consolidates this logic and fixes the bugs which currently > >> exist in > >> the MAT logic. > >> > >> The first patch adds the ImagePropertiesRecordLib implementation which > >> is a copy of the UEFI MAT logic with minor modifications to remove the > >> reliance on globabl variables and make the code unit testable. > >> > >> The second patch adds a unit test for the ImagePropertiesRecordLib. The > >> logic tests various potential layouts of the EFI memory map and runtime > >> images. 3/4 of these tests will fail which demonstrates the MAT logic > >> bugs. > >> > >> The third patch fixes the logic in the ImagePropertiesRecordLib so > >> that all of the unit tests pass and the MAT logic can be fixed by > >> using the library. > >> > >> The remaining patches add library instances to DSC files and remove > >> the image properties record logic from the SMM and UEFI MAT logic. > >> > >> Cc: Andrew Fish > >> Cc: Ard Biesheuvel > >> Cc: Dandan Bi > >> Cc: Eric Dong > >> Cc: Gerd Hoffmann > >> Cc: Guo Dong > >> Cc: Gua Guo > >> Cc: James Lu > >> Cc: Jian J Wang > >> Cc: Jiewen Yao > >> Cc: Jordan Justen > >> Cc: Leif Lindholm > >> Cc: Liming Gao > >> Cc: Rahul Kumar > >> Cc: Ray Ni > >> Cc: Sami Mujawar > >> Cc: Sean Rhodes > >> > >> Taylor Beebe (14): > >> MdeModulePkg: Add ImagePropertiesRecordLib > >> ArmVirtPkg: Add ImagePropertiesRecordLib Instance > >> EmulatorPkg: Add ImagePropertiesRecordLib Instance > >> OvmfPkg: Add ImagePropertiesRecordLib Instance > >> UefiPayloadPkg: Add ImagePropertiesRecordLib Instance > >> MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global > >> Variable > >> Use > >> MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib > >> MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test > >> MdeModulePkg: Fix Bugs in MAT Logic > >> MdeModulePkg: Add NULL checks and Return Status to > >> ImagePropertiesRecordLib > >> UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero > >> MdeModulePkg: Transition SMM MAT Logic to Use > >> ImagePropertiesRecordLib > >> MdeModulePkg: Add Logic to Create/Delete Image Properties Records > >> MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib > >> > >> MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 967 > >> +---------------- > >> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 24 +- > >> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 958 > >> +--------------- > >> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c > >> | 1144 ++++++++++++++++++++ > >> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.c > >> | 938 ++++++++++++++++ > >> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 19 +- > >> ArmVirtPkg/ArmVirt.dsc.inc | 1 + > >> EmulatorPkg/EmulatorPkg.dsc | 1 + > >> MdeModulePkg/Core/Dxe/DxeMain.h | 20 - > >> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + > >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 + > >> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h | 234 ++++ > >> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf > >> | 31 + > >> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.inf > >> | 35 + > >> MdeModulePkg/MdeModulePkg.dec | 5 + > >> MdeModulePkg/MdeModulePkg.dsc | 2 + > >> MdeModulePkg/Test/MdeModulePkgHostTest.dsc | 6 + > >> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > >> OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > >> OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > >> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + > >> OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > >> OvmfPkg/OvmfPkgIa32.dsc | 1 + > >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > >> OvmfPkg/OvmfPkgX64.dsc | 1 + > >> OvmfPkg/OvmfXen.dsc | 1 + > >> OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 1 + > >> UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > >> 28 files changed, 2524 insertions(+), 1874 deletions(-) > >> create mode 100644 > >> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c > >> create mode 100644 > >> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.c > >> create mode 100644 > >> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h > >> create mode 100644 > >> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf > >> create mode 100644 > >> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.inf > >> > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108059): https://edk2.groups.io/g/devel/message/108059 Mute This Topic: https://groups.io/mt/100553430/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-