From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C316740064 for ; Wed, 28 Aug 2024 08:02:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pvFcm3L/jFmJme59WujKJdkXu3gZJH3C0fdYaFpPcnc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1724832148; v=1; b=baFCuW38Csyz59uSWzj9AMTkGkgBg07WsEDDQ6dJgZOyyCZI7PsLL8WAEZuOjMIUnYqUq6GH C6Xuq2CSLHs4dn6jqcd1GngaizivY68cLsQ7Y8GPos5CgQbzePZIfS272c3S+deHVdsR/yOWvjg 8fTdRZk0xCT/mflIW6U9xtbwRKesC1XewBWoLwsQ5TtP9RbceHHI9+8sIpg/girP9a26w1tzo0T z82x2S24M92Bha6t6rhV8gB6bkYsVxtEyjLV+yFIazUwNWTq4BS3TRvSH4i97xfuXy3iZgbYu/h 9GN1gmDc4tNRndRWtrWhpZImtrmBprDM7VH2NO3OH8fqw== X-Received: by 127.0.0.2 with SMTP id vOYjYY7687511x7WOpQd4rXX; Wed, 28 Aug 2024 01:02:27 -0700 X-Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by mx.groups.io with SMTP id smtpd.web10.8470.1724832147074939991 for ; Wed, 28 Aug 2024 01:02:27 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 307F1A433D0 for ; Wed, 28 Aug 2024 08:02:19 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B842FC55DF8 for ; Wed, 28 Aug 2024 07:54:47 +0000 (UTC) X-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-533488ffaebso7765082e87.0 for ; Wed, 28 Aug 2024 00:54:47 -0700 (PDT) X-Gm-Message-State: t6UP9oKlZ7YuPnjDHQJKpp3Ex7686176AA= X-Google-Smtp-Source: AGHT+IGNN5fUah2UT7+1tkO+CoB5zAmfdGmG/Hqz33bdfYoBugqhe2H/g5RRJa+WmHnSA6zepOOHKJcKO44NtC6O0ks= X-Received: by 2002:a05:6512:2813:b0:52c:c032:538d with SMTP id 2adb3069b0e04-53438783fb8mr9990238e87.27.1724831685776; Wed, 28 Aug 2024 00:54:45 -0700 (PDT) MIME-Version: 1.0 References: <20240731163334.6979-1-ardb@kernel.org> <841a1869-2cd4-4ba4-aea0-12b2f1b90d86@arm.com> <42ab5584-3887-45e4-b08e-d82c8cc822e0@arm.com> <05eab044-6746-4ff7-a14d-73318542bba6@arm.com> In-Reply-To: <05eab044-6746-4ff7-a14d-73318542bba6@arm.com> From: "Ard Biesheuvel via groups.io" Date: Wed, 28 Aug 2024 09:54:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec To: Jeremy Linton Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, Abdul Lateef Attar , Abner Chang , Chuong Tran , Graeme Gregory , Marcin Juszkiewicz , Marcin Wojtas , Meenakshi Aggarwal , Narinder Dhillon , Nhi Pham , Paul Grimes , Rebecca Cran , Sami Mujawar , Thomas Abraham , Wenyi Xie , Ling Jia , Peng Xie , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 28 Aug 2024 01:02:27 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=baFCuW38; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 28 Aug 2024 at 06:12, Jeremy Linton wrote: > > On 8/27/24 11:37, Ard Biesheuvel wrote: > > On Tue, 6 Aug 2024 at 16:10, Leif Lindholm wrote: > >> > >> On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote: > >>> Hi, > >>> > >>> > >>> On 8/1/24 09:44, Ard Biesheuvel wrote: > >>>> On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > >>>>> > >>>>> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> On 7/31/24 11:33, Ard Biesheuvel wrote: > >>>>>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg > >>>>>>> to the new versions called Sec or PeilessSec - these have been cleaned > >>>>>>> up and stripped of obsolete functionality related to multicore boot, > >>>>>>> which is not something UEFI should concern itself with. > >>>>>>> > >>>>>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first. > >>>>>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers > >>>>>>> can be retired. > >>>>>> > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> Thanks for cleaning this up, but the rpi4 fails with: > >>>>>> > >>>>>> Decompress GetInfo Failed - Invalid Parameter > >>>>>> > >>>>>> ASSERT_EFI_ERROR (Status = Not Found) > >>>>>> ASSERT [PeilessSec] > >>>>>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158): > >>>>>> !(((INTN)(RETURN_STATUS)(Status)) < 0) > >>>>>> > >>>>> > >>>>> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild. > >>>>> > >>>>> I'll look into it. > >>>> > >>>> The below should fix it - I'll update all DSCs with this if it works > >>>> for you as well. > >>> > >>> That fixes the problem above. Thanks! > >> > >> Can I take that as an R-b on the Rpi changes in this set? > >> > > > > In the interest of progress on the EDK2 side, I intend to merge the > > remaining 2/2 of this set tomorrow, on the basis that it is primarily > > a code refactoring change that works correctly on the platforms that I > > can readily test (RPi3 / RPi4). > > > > If anyone objects to this, please leave a reply on the thread. > > Ok.. > > For the rpi4 parts > > Reviewed-by: Jeremy Linton > > and > > Tested-by: Jeremy Linton > > (although EDK doesn't use tested-by does it?) > It does. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120422): https://edk2.groups.io/g/devel/message/120422 Mute This Topic: https://groups.io/mt/107649429/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-