From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.5194.1668589953740946184 for ; Wed, 16 Nov 2022 01:12:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bJAsvgIw; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DF8E61B18 for ; Wed, 16 Nov 2022 09:12:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7629DC4347C for ; Wed, 16 Nov 2022 09:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668589952; bh=nt5N79ky4uTO2cG+RzLbgG1rCXHIAhxmRnmURf4708Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bJAsvgIw22ysSQxYqAdd25a1SDCMLDbhhF7rzv/hg3V/8PXXCXP2oARmvz0ODse1w xYwbTY1ajsae8/tYu9EMxhSN3Lh1CTFzXMxJu4/1W4zcQ8hwSEF5L4Kw6wkVjTMn4J w8o8xSH/THws7cE6KZhPMENasqvFJ0QIOlojpmMF5U9FRwAI9LHdIOBX9G7KJZazbo UAOkSpQ4dLTDbtt8+NL9FEzcvgcz1eCFHJEhPo19hbuqITHvtJxX9+EpH7/bnpmFAp Yr0teLF3qmYznkxJqGQWpnDiqB4U+wQm8tTLhg9qxsfJ29yvPrmmft8aXhXt2YgeoH ZecEFg46ZlXKA== Received: by mail-lf1-f48.google.com with SMTP id c1so28504149lfi.7 for ; Wed, 16 Nov 2022 01:12:32 -0800 (PST) X-Gm-Message-State: ANoB5pleJ10JD4iT/60l0SUjXOV9APP2CbhJvR8o+Upgbc0+9d+Ev5eC XvuvA+w6TJTuwqqNP5k0emKXVIL4CeD3fYqRYkI= X-Google-Smtp-Source: AA0mqf6SYo7Npv9uboN7hGSpN/KqqqiqoaSaFGOQmVGBUe//wf7gtpKsQxh6X0yasdHvD+daIS9hTAa5dSUVlvq4bdk= X-Received: by 2002:ac2:46cc:0:b0:4a6:3ed2:3717 with SMTP id p12-20020ac246cc000000b004a63ed23717mr7432399lfo.637.1668589950346; Wed, 16 Nov 2022 01:12:30 -0800 (PST) MIME-Version: 1.0 References: <20221114144347.1664317-1-Pierre.Gondois@arm.com> <1727A2869BB78C87.23030@groups.io> <020601d8f95b$92a1ff60$b7e5fe20$@byosoft.com.cn> In-Reply-To: <020601d8f95b$92a1ff60$b7e5fe20$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Wed, 16 Nov 2022 10:12:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: Pierre.Gondois@arm.com, Ard Biesheuvel , Leif Lindholm , Sami Mujawar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 16 Nov 2022 at 02:34, gaoliming via groups.io wrote: > > PR https://github.com/tianocore/edk2/pull/3641 is created to merge it. > Thank you Liming. > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 gaoliming via > > groups.io > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8815=E6=97= =A5 10:55 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; ardb@kernel.org; Pie= rre.Gondois@arm.com > > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; 'Leif= Lindholm' > > ; 'Sami Mujawar' > > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 1/1][edk2-s= table202211] > > ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() > > > > Ard: > > I am OK to merge it for this stable tag. I will do it. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Ard > > > Biesheuvel > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8814=E6= =97=A5 23:10 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Pierre.Gondois@arm.com > > > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel > > ; > > > Leif Lindholm ; Sami Mujawar > > > ; Liming Gao > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] > > ArmPkg/ArmTrngLib: > > > Remove ASSERT in GetArmTrngVersion() > > > > > > On Mon, 14 Nov 2022 at 15:44, wrote: > > > > > > > > From: Pierre Gondois > > > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4150 > > > > > > > > GetArmTrngVersion() is used to check the presence of an Arm > > > > Trng. If not found, an ASSERT prevents from booting in DEBUG > > > > builds. > > > > Remove this ASSERT. > > > > > > > > Reported-by: Sami Mujawar > > > > Signed-off-by: Pierre Gondois > > > > > > Acked-by: Ard Biesheuvel > > > > > > Liming: please merge this if you are ok with it, or I can merge it if > > > you prefer. > > > > > > > --- > > > > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > > index fdabc02cd39c..3278722320c8 100644 > > > > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > > @@ -344,7 +344,6 @@ ArmTrngLibConstructor ( > > > > > > > > Status =3D GetArmTrngVersion (&MajorRev, &MinorRev); > > > > if (RETURN_ERROR (Status)) { > > > > - ASSERT_RETURN_ERROR (Status); > > > > goto ErrorHandler; > > > > } > > > > > > > > -- > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >