From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web11.3962.1623216598297676727
 for <devel@edk2.groups.io>;
 Tue, 08 Jun 2021 22:29:58 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V4AmiY82;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 95DED61249
	for <devel@edk2.groups.io>; Wed,  9 Jun 2021 05:29:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1623216597;
	bh=D3p1hscOGznP6+4WlUHbNJlIptjIkr01o+I/0+w/oTo=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=V4AmiY82y3DLV55+tGUHkYE0VocCmO4UM5upEZsAIIoaALTegezg9aud3yUKLToIb
	 1nsWGAeWger/sjBqhsnfF4n7kBASmDJwXILB6O3reX/KXp5KxylQo/4UFN5Rf2+DWB
	 OcQHh/4U7g3bXa1s/TRrBJL58fSdY3WNNTXeoNyUp7NITxl4Aw2DTnKopiOJwCAfUC
	 1BsU7dL2OO/NRaTlqJiNS3YpURgFylSaK5X53CZb7picR3KJcUX+FVcZzIGvtntuHx
	 3WAi27G1/QSnpTqsKK1iB0la9+2rQ5tcglDeiPAqQ+iYcGFIVbWo02VNYPQ/nVYmqJ
	 yEzakJ8EtWU+g==
Received: by mail-ot1-f46.google.com with SMTP id q5-20020a9d66450000b02903f18d65089fso6572162otm.11
        for <devel@edk2.groups.io>; Tue, 08 Jun 2021 22:29:57 -0700 (PDT)
X-Gm-Message-State: AOAM533RqKVvy3AHfF7t3v9z0C7dTCKzpfTyk4qLjSTsaLbKhRPNJ7AX
	ataLE0FPEh0+G7fxDmUdL+KSd8zrZ0vNZqn68Uc=
X-Google-Smtp-Source: ABdhPJy1Yum73YiocUlnCn2pWi0YxQ0cX6j6T+QAyMKeivQyi0ucfH0c1uuZJNVs9j+zEvitckRw3Y8wToPIvpCE5kc=
X-Received: by 2002:a9d:4004:: with SMTP id m4mr418019ote.108.1623216597005;
 Tue, 08 Jun 2021 22:29:57 -0700 (PDT)
MIME-Version: 1.0
References: <20210526100724.5359-1-nhi@os.amperecomputing.com> <20210526100724.5359-18-nhi@os.amperecomputing.com>
In-Reply-To: <20210526100724.5359-18-nhi@os.amperecomputing.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 9 Jun 2021 07:29:45 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGmqZUr1jWuhUH7VfFeLJrdyQ_D8O=eXXGgWb6EUQh7tQ@mail.gmail.com>
Message-ID: <CAMj1kXGmqZUr1jWuhUH7VfFeLJrdyQ_D8O=eXXGgWb6EUQh7tQ@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v2 16/32] AmpereAltraPkg: Add PciHostBridge driver
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Vu Nguyen <vunguyen@os.amperecomputing.com>, 
	Thang Nguyen <thang@os.amperecomputing.com>, Chuong Tran <chuong@os.amperecomputing.com>, 
	Phong Vo <phong@os.amperecomputing.com>, Leif Lindholm <leif@nuviainc.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Nate DeSimone <nathaniel.l.desimone@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 26 May 2021 at 12:12, Nhi Pham <nhi@os.amperecomputing.com> wrote:
>
> From: Vu Nguyen <vunguyen@os.amperecomputing.com>
>
> The roles of this driver:
> * Consume PcieCoreLib to initialize all enable PCIe controllers.
> * Produce neccessary protocols like RootBridgeIo an ResourceAllocation
>   which will be used later by PciBus.
>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>

Why do you need a re-implementation of PciHostBridgeDxe for any of
this? There is very little h/w specific code there, and it is all
customizable using PciHostBridgeLib and PciSegmentLib (among others)

There are a couple of examples of this in edk2-platforms - please take
a look at those, and if that does not give you enough wiggle room,
let's see if we can accommodate your needs in PciHostBridgeDxe itself.

-- 
Ard.