From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.27593.1650883034209342223 for ; Mon, 25 Apr 2022 03:37:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mxWS1Fkc; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31C6560EC5 for ; Mon, 25 Apr 2022 10:37:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A7BFC385A7 for ; Mon, 25 Apr 2022 10:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650883032; bh=eb8poG3f8Uuww98XWNNIA+tsDd5zPiTFvp1rlgWdByM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mxWS1FkccjB+pwqOB8FAgk1FFfFPlKtg8oNlITdOBwPcgRJq6fWwrxvUyRPC5rG5I iDPSPNrlyx0YF+VMl19xiznra2IMPuBe3lLPCmgAIE9EfCJ8p9e7JCG+h8WQA1bw7n VQe1BqIDv9UEnL1vPGe7hgygnYhGWUdrcVO5SdlZz34KT6WUc+XYwBDSCT68Ov3UY9 6Ml4dERTgkRdyF/Kxr3WW/VzZQjaAjdcI9ZCzHRAVfTI82IQMaelgeBGETMszRrxMB nzkvCt1kywW4xxqA2tVuquQAxY+5GluFYGMdrL5qJ7vhcM3g0ufESjIYxOsLgfiufR oJ/aKA5JC2XDQ== Received: by mail-ot1-f54.google.com with SMTP id u17-20020a9d4d91000000b00605a73abac1so2469106otk.7 for ; Mon, 25 Apr 2022 03:37:12 -0700 (PDT) X-Gm-Message-State: AOAM533czXr2D/6DtyEdYyJ72Dl0duJpGpKwcFOvsKCZxyJn0b4zieK8 zQUNBM2HFVYDu41TKqoA6MxXhqUK3H8XAJZqI6Q= X-Google-Smtp-Source: ABdhPJxfrmNDRSEZqqPYvNGiwBzpj9EHpdrOFncg5CyfkDo3JyTmyC84QgTOnNHAKcg9ikAEd3RcY3A3IMNbgi7D6v4= X-Received: by 2002:a05:6830:242d:b0:605:589f:e2a7 with SMTP id k13-20020a056830242d00b00605589fe2a7mr6128064ots.71.1650883031822; Mon, 25 Apr 2022 03:37:11 -0700 (PDT) MIME-Version: 1.0 References: <20220425103446.496763-1-kraxel@redhat.com> In-Reply-To: <20220425103446.496763-1-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Mon, 25 Apr 2022 12:37:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/6] OvmfPkg/Microvm/pcie: add pcie support To: Gerd Hoffmann Cc: edk2-devel-groups-io , Jiewen Yao , Oliver Steffen , Leif Lindholm , Pawel Polawski , Hao A Wu , Abner Chang , Liming Gao , Ray Ni , Jordan Justen , Jian J Wang , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Mon, 25 Apr 2022 at 12:34, Gerd Hoffmann wrote: > > Needs two little tweaks in PCI code because microvm supports mmio only. > Other than that just wire up the existing code (the PCIe host adapter > used by microvm is the same (virtual) hardware used by the arm/aarch64 > virtual machines). > > v6: > - codestyle fix (Abner Chang). > > v5: > - codestyle (uncrustify) fix. > > v4: > - update PciHostBridge check (Abner Chang). > > v3: > - rebase to latest master, adapt to PlatformInitLib. > - rework PhysMemAddressWidth handling for microvm. > > v2: > - rebase to latest master > - pick up review tags > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777 > > Gerd Hoffmann (6): > MdeModulePkg/PciHostBridge: io range is not mandatory > OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory > OvmfPkg/Platform: unfix PcdPciExpressBaseAddress > OvmfPkg/Microvm/pcie: no vbeshim please > OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak > OvmfPkg/Microvm/pcie: add pcie support > Thanks Gerd. I'm happy to take these, but not without an ack from the MdeModulePkg maintainers. > OvmfPkg/Microvm/MicrovmX64.dsc | 40 ++++++++++------- > .../PlatformInitLib/PlatformInitLib.inf | 4 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- > .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 ++ > .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++++++++++--------- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 45 ++++++++++++++++++- > OvmfPkg/Library/PlatformInitLib/Platform.c | 4 +- > OvmfPkg/PlatformPei/Platform.c | 2 +- > OvmfPkg/QemuVideoDxe/VbeShim.c | 2 + > OvmfPkg/Microvm/README | 2 +- > 10 files changed, 104 insertions(+), 45 deletions(-) > > -- > 2.35.1 >