From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web12.9938.1629638769886315595 for ; Sun, 22 Aug 2021 06:26:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TYTsunDa; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id AB86D6101C for ; Sun, 22 Aug 2021 13:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629638767; bh=bqPpBMd9nZdG4H+iWN+MV278r/xVyrS22Hy08bvMqdo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TYTsunDaGqlOMPwRY85yXPuNN/tm09/nBeVwVyKdU6UA0kNEL4xvz3s2cu/GvV7Bz cBh+GgEhLpotJw2+aYsXasN1Ajn0lVH1GLm3tJe0u/UyGnhxP/WF6k3cQacmchVhlx X7zBM0yzOSf3w2gcuUP2G/o7Wjb6UvX9vCX/UhcamVoo62ugbhiGbNENYPZq2ws6BY tGyp9q3yEcD92eFinZ2nbnAUpLwfIkGd0kS42tNoKq1t2HHtBQv6dCeHmOTw8zANut dR7kb/DKSYiFgnQPNftJVYRBvwh0ZN9CvrwiEY7GcUpcbHLNPonMpg/TWN6W1vnu2+ a6MPJObAg3O+w== Received: by mail-ot1-f48.google.com with SMTP id 61-20020a9d0d430000b02903eabfc221a9so28477635oti.0 for ; Sun, 22 Aug 2021 06:26:07 -0700 (PDT) X-Gm-Message-State: AOAM530ZKvKjWFXau28yVq+79XAEbp7Gza7a72FK+NDZvaKP7FNtdvYv K8coWMSpPnRVHT4R6JJqro2cosJk/Qzt0ZHBMx8= X-Google-Smtp-Source: ABdhPJxWuEIaEo8s+Dz3Cpei2eqtJ7kkUaY1I235J2Kuu/F6YBKok+1MJh3B1Qn5/ZAkEV7XLUiu1T+XRQK5BbEjMt4= X-Received: by 2002:a05:6830:444:: with SMTP id d4mr8184691otc.108.1629638767038; Sun, 22 Aug 2021 06:26:07 -0700 (PDT) MIME-Version: 1.0 References: <20210821020018.246379-1-rebecca@bsdio.com> <20210821020018.246379-2-rebecca@bsdio.com> In-Reply-To: <20210821020018.246379-2-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Sun, 22 Aug 2021 15:25:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds To: Rebecca Cran Cc: Leif Lindholm , Michael D Kinney , Ard Biesheuvel , edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Sat, 21 Aug 2021 at 04:00, Rebecca Cran wrote: > > BdsDxe depends on VariablePolicyHelperLib, so move it out from > VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and > LibraryClasses.DXE_RUNTIMER_DRIVER. > > This fixes the build of AMD/OverdriveBoard and > SoftIron/Overdrive1000Board. > > Signed-off-by: Rebecca Cran Thanks for the fix Pushed as a47606201fed..0efab5febe78 > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 ++- > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index bc8d8e37d6c1..31be381cf7f6 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -209,6 +209,7 @@ DEFINE X64EMU_ENABLE = FALSE > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > @@ -218,6 +219,7 @@ DEFINE X64EMU_ENABLE = FALSE > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -578,7 +580,6 @@ DEFINE X64EMU_ENABLE = FALSE > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > } > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index 38620b3e4d3b..7211f3e5629e 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -203,6 +203,7 @@ DEFINE NUM_CORES = 4 > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > @@ -212,6 +213,7 @@ DEFINE NUM_CORES = 4 > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -513,7 +515,6 @@ DEFINE NUM_CORES = 4 > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > } > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > -- > 2.31.1 > >