From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc
Date: Sat, 9 Dec 2023 08:55:03 +0100 [thread overview]
Message-ID: <CAMj1kXGoZyVbhHTs=crWRVZheTWX9+mFsomnfuQSLKUc4jdckQ@mail.gmail.com> (raw)
In-Reply-To: <20231209001954.155789-5-rebecca@os.amperecomputing.com>
On Sat, 9 Dec 2023 at 01:20, Rebecca Cran
<rebecca@os.amperecomputing.com> wrote:
>
> Update the debug level comments in ArmVirt.dsc.inc to sync with
> MdePkg/Include/Library/DebugLib.h.
>
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 42 ++++++++++----------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 6bc72f1decbd..9b23ef97ec5f 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -315,26 +315,28 @@ [PcdsFixedAtBuild.common]
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f
> !endif
>
> - # DEBUG_INIT 0x00000001 // Initialization
> - # DEBUG_WARN 0x00000002 // Warnings
> - # DEBUG_LOAD 0x00000004 // Load events
> - # DEBUG_FS 0x00000008 // EFI File system
> - # DEBUG_POOL 0x00000010 // Alloc & Free (pool)
> - # DEBUG_PAGE 0x00000020 // Alloc & Free (page)
> - # DEBUG_INFO 0x00000040 // Informational debug messages
> - # DEBUG_DISPATCH 0x00000080 // PEI/DXE/SMM Dispatchers
> - # DEBUG_VARIABLE 0x00000100 // Variable
> - # DEBUG_BM 0x00000400 // Boot Manager
> - # DEBUG_BLKIO 0x00001000 // BlkIo Driver
> - # DEBUG_NET 0x00004000 // SNP Driver
> - # DEBUG_UNDI 0x00010000 // UNDI Driver
> - # DEBUG_LOADFILE 0x00020000 // LoadFile
> - # DEBUG_EVENT 0x00080000 // Event messages
> - # DEBUG_GCD 0x00100000 // Global Coherency Database changes
> - # DEBUG_CACHE 0x00200000 // Memory range cachability changes
> - # DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may
> - # // significantly impact boot performance
> - # DEBUG_ERROR 0x80000000 // Error
> + # DEBUG_INIT 0x00000001 // Initialization
> + # DEBUG_WARN 0x00000002 // Warnings
> + # DEBUG_LOAD 0x00000004 // Load events
> + # DEBUG_FS 0x00000008 // EFI File system
> + # DEBUG_POOL 0x00000010 // Alloc & Free (pool)
> + # DEBUG_PAGE 0x00000020 // Alloc & Free (page)
> + # DEBUG_INFO 0x00000040 // Informational debug messages
> + # DEBUG_DISPATCH 0x00000080 // PEI/DXE/SMM Dispatchers
> + # DEBUG_VARIABLE 0x00000100 // Variable
> + # DEBUG_BM 0x00000400 // Boot Manager
> + # DEBUG_BLKIO 0x00001000 // BlkIo Driver
> + # DEBUG_NET 0x00004000 // Network Io Driver
> + # DEBUG_UNDI 0x00010000 // UNDI Driver
> + # DEBUG_LOADFILE 0x00020000 // LoadFile
> + # DEBUG_EVENT 0x00080000 // Event messages
> + # DEBUG_GCD 0x00100000 // Global Coherency Database changes
> + # DEBUG_CACHE 0x00200000 // Memory range cachability changes
> + # DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may
> + # // significantly impact boot performance
> + # DEBUG_MANAGEABILITY 0x00800000 // Detailed debug and payload manageability messages
> + # // related to modules such as Redfish, IPMI, MCTP etc.
> + # DEBUG_ERROR 0x80000000 // Error
> !if $(TARGET) != RELEASE
> gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
> !endif
> --
> 2.34.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112250): https://edk2.groups.io/g/devel/message/112250
Mute This Topic: https://groups.io/mt/103066386/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-09 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 0:19 [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments Rebecca Cran via groups.io
2023-12-09 0:19 ` [edk2-devel] [PATCH 1/4] MdePkg: Improve wording of manageability debug level comment Rebecca Cran via groups.io
2023-12-09 0:19 ` [edk2-devel] [PATCH 2/4] MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel Rebecca Cran via groups.io
2023-12-09 0:19 ` [edk2-devel] [PATCH 3/4] MdePkg: Update MdePkg.uni with manageability debug level Rebecca Cran via groups.io
2023-12-09 0:19 ` [edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc Rebecca Cran via groups.io
2023-12-09 7:55 ` Ard Biesheuvel [this message]
2023-12-09 0:33 ` [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments Rebecca Cran via groups.io
2023-12-12 1:17 ` Laszlo Ersek
2023-12-12 1:19 ` Rebecca Cran
2023-12-09 1:03 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGoZyVbhHTs=crWRVZheTWX9+mFsomnfuQSLKUc4jdckQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox