From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web09.222.1626456463218028532
 for <devel@edk2.groups.io>;
 Fri, 16 Jul 2021 10:27:43 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cuM4m/Fq;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6CEB861403
	for <devel@edk2.groups.io>; Fri, 16 Jul 2021 17:27:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1626456462;
	bh=T1EIUkYIV7RWL1gf4eUmLakt3fawYvkRxJHOobVJE9g=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=cuM4m/FqvRKUJ2XDfpupu3YE+nEwMe/0jCPgLkHf3FN2/xKBSK/0FHqi/iGt8hpth
	 fNzzwzTqIzsV56HpDOVWjpctf6PnwbAwiCrOxT+3aZzkxRfY5m4N7IUDuRW1HUS7Et
	 +eiI6ZBlduQyZcmXCec6iQcVV9KnW6c/N05WKnKhgehzNf4y7DqGj0zDvsxbA0rVdU
	 UewwcOnnl8aBvT/vW9o8Kt23LY/dTpQEW14WboXFmG6wChlNh4oFCvoqITcFJNHMEz
	 pMhmcfwnYwo1nOWJ70B8lR0HPxTCve+x+PJVp73KzJqN8dkYERxcx73okOZ1Bhjqms
	 3LruFeBaXv+aA==
Received: by mail-ot1-f41.google.com with SMTP id t4-20020a05683014c4b02904cd671b911bso2553639otq.1
        for <devel@edk2.groups.io>; Fri, 16 Jul 2021 10:27:42 -0700 (PDT)
X-Gm-Message-State: AOAM532HenITfQwBxYJi0xE6tPHQNGWuMt2IvgOoLAFmOMmsjgNBjk53
	hGcJi+yHl/qSZhIfwPSsdJIGDMF9NPJyfh9y43A=
X-Google-Smtp-Source: ABdhPJylHQJViR4MOMLVscLSnsbLrl+Fqsjx82PFRWT/FOkK237gHZg50NGENCQG3i5SNL1AMycbivglMDL8GjIWYlk=
X-Received: by 2002:a05:6830:3494:: with SMTP id c20mr2569734otu.108.1626456461810;
 Fri, 16 Jul 2021 10:27:41 -0700 (PDT)
MIME-Version: 1.0
References: <20210705100641.97166-1-jianyong.wu@arm.com> <CAMj1kXHsk=7jp7YVXkXPnM6Gv_PW4ZDvMOMgzFkKTMeWJxhzDA@mail.gmail.com>
In-Reply-To: <CAMj1kXHsk=7jp7YVXkXPnM6Gv_PW4ZDvMOMgzFkKTMeWJxhzDA@mail.gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 16 Jul 2021 19:27:21 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGpKo7Z-+xpLY5Sz+0RRSuXGTmZFWxB6WhdoRVzyv-fxQ@mail.gmail.com>
Message-ID: <CAMj1kXGpKo7Z-+xpLY5Sz+0RRSuXGTmZFWxB6WhdoRVzyv-fxQ@mail.gmail.com>
Subject: Re: [PATCH v4 0/3] Enable Cloud Hypervisor support in edk2
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Laszlo Ersek <lersek@redhat.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, justin.he@arm.com
Content-Type: text/plain; charset="UTF-8"

On Fri, 16 Jul 2021 at 19:25, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 5 Jul 2021 at 12:06, Jianyong Wu <jianyong.wu@arm.com> wrote:
> >
> > Cloud Hypervisor is an open source Virtual Machine Monitor (VMM) that
> > runs on top of KVM. Cloud Hypervisor is implemented in Rust and is based
> > on the rust-vmm crates. See [1] to find more.
> >
> > To support UEFI, Cloud Hypervisor is introduced here.
> > There are 2 parts to be considered to do this enablement, that is:
> >   1. specific ACPI service implementation compared with qemu, there is no
> >      device like Fw-cfg, so we have no elegant way to get the RSDP address.
> >      A specific ACPI implementation is introduced here.
> >
> >   2. build configuration file for Cloud Hypervisor
> >
> > Change log:
> >
> > v3 to v4:
> >      (1) remove Tpm support in dsc file
> >      (2) refine Acpi table install code base on Sami's comments in v3
> >
> > v2 to v3:
> >      (1) reuse qemu's memory initialization lib as they are in nearly the same
> > memory laout.
> >      (2) split Acpi implemetation into PlatformHasAcpi and
> > InstallAcpiTable.
> >      (3) remove lots of dependencies from qemu like "*Fwcfg*" lib.
> >      (4) lots of code cleanup work to let it more approach to edk2 code
> > style.
> >
> > [1] https://github.com/cloud-hypervisor/cloud-hypervisor
> >
> > Jianyong Wu (3):
> >   Acpi: reimplement PlatformHasAcpi for Cloud Hypervisor
> >   Acpi: Install Acpi tables for Cloud hypervisor
> >   ArmVirtCloudHv: support Cloud Hypervisor in edk2
> >
>
> Sami, any thoughts on this code?
>


... or did you already merge the entire series? (My mailbox is
overflowing a bit after 4 weeks of vacation :-))


>
> >  ArmVirtPkg/ArmVirtPkg.dec                     |   6 +
> >  ArmVirtPkg/ArmVirtCloudHv.dsc                 | 364 ++++++++++++++++++
> >  ArmVirtPkg/ArmVirtCloudHv.fdf                 | 258 +++++++++++++
> >  .../CloudHvAcpiPlatformDxe.inf                |  47 +++
> >  .../CloudHvHasAcpiDtDxe.inf                   |  43 +++
> >  .../CloudHvAcpiPlatformDxe/CloudHvAcpi.c      | 155 ++++++++
> >  .../CloudHvHasAcpiDtDxe.c                     |  69 ++++
> >  7 files changed, 942 insertions(+)
> >  create mode 100644 ArmVirtPkg/ArmVirtCloudHv.dsc
> >  create mode 100644 ArmVirtPkg/ArmVirtCloudHv.fdf
> >  create mode 100644 ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpiPlatformDxe.inf
> >  create mode 100644 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> >  create mode 100644 ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpi.c
> >  create mode 100644 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.c
> >
> > --
> > 2.17.1
> >