public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>,
	Michael Kinney <michael.d.kinney@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>,
	 Star Zeng <star.zeng@intel.com>
Subject: Re: [edk2-devel] [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM override
Date: Thu, 27 Jan 2022 13:45:33 +0100	[thread overview]
Message-ID: <CAMj1kXGpTiBiCUOhZmM+c_-7zuveawYqHQ9LL8rfqjMXSSCm0g@mail.gmail.com> (raw)
In-Reply-To: <20220122014056.1367-1-michael.d.kinney@intel.com>

On Sat, 22 Jan 2022 at 02:41, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3811
>
> Remove ASSERT() statements that are triggered if a platform provides
> an override of PCI ROM attached to a PCI Controller.  The PCI Platform
> Protocol allows the platform to provide a PCI ROM image for a PCI
> Controller.  This works for PCI Controllers that do not have an attached
> PCI ROM, but the platform is not allowed to replace the PCI ROM for a
> PCI Controller that has its own PCI ROM.  Removing these ASSERT()
> statements enables this additional use case.
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c
> index 5535bd3013b8..cb845ec2b186 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c
> @@ -58,10 +58,9 @@ PciRomAddImageMapping (
>      {
>        //
>        // Expect once RomImage and RomSize are recorded, they will be passed in
> -      // later when updating ImageHandle
> +      // later when updating ImageHandle. They may also be updated with new
> +      // values if the platform provides an override of RomImage and RomSize.
>        //
> -      ASSERT ((mRomImageTable[Index].RomImage == NULL) || (RomImage == mRomImageTable[Index].RomImage));
> -      ASSERT ((mRomImageTable[Index].RomSize  == 0) || (RomSize  == mRomImageTable[Index].RomSize));
>        break;
>      }
>    }
> --
> 2.32.0.windows.1
>
>
>
> 
>
>

      parent reply	other threads:[~2022-01-27 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22  1:40 [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM override Michael D Kinney
2022-01-25  6:55 ` Zeng, Star
2022-01-27  3:34 ` Ni, Ray
2022-01-27 12:45 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGpTiBiCUOhZmM+c_-7zuveawYqHQ9LL8rfqjMXSSCm0g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox