From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.15293.1683722254654524988 for ; Wed, 10 May 2023 05:37:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OY6EuNj0; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26ED0611B1 for ; Wed, 10 May 2023 12:37:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5350CC4339E for ; Wed, 10 May 2023 12:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683722253; bh=be0NrNeD6MbU2AeaFdJcPTcR1/130KJPuuyJiVnfWZQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OY6EuNj0juH0jAKMyUZG8Fv1WNEj5IQGyh1OntzPHe4DkRTRekAvNiUWN1dFG8ogk 55BPI7pjxoBSi6dJp+9MhZGuWqNTCJVlQBC4io/i7FOkpDWlTlI3QbxmBkw/8dXmgs wtVmGtdH7Is584OdRvMTMjSvlZCUL67YutEV/CgM3sXWewHi7MNEooD9A1B1HGPZBW V9CY+z61GUmRbHzLx4M2sfRU2zdm0Hwe7sfIpsuA/22keCXuqsdhLkpY2OaIqdJRjw jKxTVc19PPy1I6ta46dTDc8HEL0XWGz0bCHyfDSfPc2nyp7fIzjaOHq9kf+KdBlWfQ LG+HvAcrZgWvQ== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4ecb137af7eso8092609e87.2 for ; Wed, 10 May 2023 05:37:33 -0700 (PDT) X-Gm-Message-State: AC+VfDzVFGv3RWC8UqyZbnAj27a2nys26CWBf3QjuHOnrQj5tFrEYl7Z GyphyU1bPCOtUxL7q/zRwCuWL2hdP55qim5MzdM= X-Google-Smtp-Source: ACHHUZ6Dsh7sdcFjhU8Dr5yiZYZCF7KGu9iJmT+Ymj61joIJwKX3Y0qovgCZRxFnoShUcBCQA/45SiwJRXk9y35D8h0= X-Received: by 2002:a05:6512:964:b0:4e8:5112:1ff2 with SMTP id v4-20020a056512096400b004e851121ff2mr1467779lft.27.1683722251342; Wed, 10 May 2023 05:37:31 -0700 (PDT) MIME-Version: 1.0 References: <20230510123141.1880782-1-rebecca@bsdio.com> In-Reply-To: <20230510123141.1880782-1-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Wed, 10 May 2023 14:37:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template To: Rebecca Cran Cc: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen Content-Type: text/plain; charset="UTF-8" On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote: > > This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. > > While GCC uses objcopy for the OBJCOPY command, it's not needed for the > CLANGDWARF toolchain and can be left as echo. > Are you sure you want to change this for IA32 and X86 as well? I'm not sure what the significance is, I suppose it sets the debuglink on the copies of the dll files? > Signed-off-by: Rebecca Cran > --- > BaseTools/Conf/tools_def.template | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index b3c822f0bc20..042b1e142b1b 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1864,7 +1864,6 @@ DEFINE CLANGDWARF_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGDWARF_ > ########################### > # CLANGDWARF IA32 definitions > ########################### > -*_CLANGDWARF_IA32_OBJCOPY_PATH = DEF(CLANGDWARF_IA32_PREFIX)llvm-objcopy > *_CLANGDWARF_IA32_CC_PATH = DEF(CLANGDWARF_IA32_PREFIX)clang > *_CLANGDWARF_IA32_SLINK_PATH = DEF(CLANGDWARF_IA32_PREFIX)llvm-ar > *_CLANGDWARF_IA32_DLINK_PATH = DEF(CLANGDWARF_IA32_PREFIX)clang > @@ -1901,7 +1900,6 @@ NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS = DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 - > ########################## > # CLANGDWARF X64 definitions > ########################## > -*_CLANGDWARF_X64_OBJCOPY_PATH = DEF(CLANGDWARF_X64_PREFIX)llvm-objcopy > *_CLANGDWARF_X64_CC_PATH = DEF(CLANGDWARF_X64_PREFIX)clang > *_CLANGDWARF_X64_SLINK_PATH = DEF(CLANGDWARF_X64_PREFIX)llvm-ar > *_CLANGDWARF_X64_DLINK_PATH = DEF(CLANGDWARF_X64_PREFIX)clang > @@ -1949,7 +1947,6 @@ DEFINE CLANGDWARF_ARM_DLINK_FLAGS = DEF(CLANGDWARF_ARM_TARGET) DEF(GCC_ARM_DLI > *_CLANGDWARF_ARM_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) > *_CLANGDWARF_ARM_DTCPP_FLAGS = DEF(GCC_DTCPP_FLAGS) > > -*_CLANGDWARF_ARM_OBJCOPY_PATH = ENV(CLANGDWARF_BIN)llvm-objcopy > *_CLANGDWARF_ARM_CC_PATH = ENV(CLANGDWARF_BIN)clang > *_CLANGDWARF_ARM_ASM_PATH = ENV(CLANGDWARF_BIN)clang > *_CLANGDWARF_ARM_PP_PATH = ENV(CLANGDWARF_BIN)clang > @@ -1994,7 +1991,6 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > *_CLANGDWARF_AARCH64_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) > *_CLANGDWARF_AARCH64_DTCPP_FLAGS = DEF(GCC_DTCPP_FLAGS) > > -*_CLANGDWARF_AARCH64_OBJCOPY_PATH = ENV(CLANGDWARF_BIN)llvm-objcopy > *_CLANGDWARF_AARCH64_CC_PATH = ENV(CLANGDWARF_BIN)clang > *_CLANGDWARF_AARCH64_ASM_PATH = ENV(CLANGDWARF_BIN)clang > *_CLANGDWARF_AARCH64_PP_PATH = ENV(CLANGDWARF_BIN)clang > -- > 2.39.2 >