Duplicate Files for StandaloneMmDriverEntryPoint.h

Duplicate Files for StandaloneMmDriverEntryPoint.h

[Michael Kubacki]

Is there a particular reason two copies of 
StandaloneMmDriverEntryPoint.h exist in the edk2 repo?

1. MdePkg
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h

2. StandaloneMmPkg
https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h

The only substantial difference (apart from copyright and comment 
differences) is that the StandaloneMmPkg instance contains a function 
declaration for EfiMain().

Thanks,
Michael

Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

[Laszlo Ersek]

Hi Michael,

On 02/22/21 23:11, Michael Kubacki wrote:
> Is there a particular reason two copies of
> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> 
> 1. MdePkg
> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> 2. StandaloneMmPkg
> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> The only substantial difference (apart from copyright and comment
> differences) is that the StandaloneMmPkg instance contains a function
> declaration for EfiMain().

I believe this may have been an omission in commit d6253d2f9a33
("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
driver", 2019-03-11).

At that point, both the library class & instance had been migrated to
MdePkg (commits 7df4764e6a81a and 5866d4992396).

Can you propose a patch (unless I'm wrong, of course)?

Thanks
Laszlo

Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

[Ard Biesheuvel]

On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Hi Michael,
>
> On 02/22/21 23:11, Michael Kubacki wrote:
> > Is there a particular reason two copies of
> > StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> >
> > 1. MdePkg
> > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > 2. StandaloneMmPkg
> > https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > The only substantial difference (apart from copyright and comment
> > differences) is that the StandaloneMmPkg instance contains a function
> > declaration for EfiMain().
>
> I believe this may have been an omission in commit d6253d2f9a33
> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
> driver", 2019-03-11).
>
> At that point, both the library class & instance had been migrated to
> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>
> Can you propose a patch (unless I'm wrong, of course)?
>

I think you are correct.

For a patch that deletes

StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h

and any stale references to it that may exist:

Acked-by: Ard Biesheuvel <ardb@kernel.org>

Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

[Michael Kubacki]

Thanks for the background. I'll go ahead and send that patch.

On 2/23/2021 11:51 PM, Ard Biesheuvel wrote:
> On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> Hi Michael,
>>
>> On 02/22/21 23:11, Michael Kubacki wrote:
>>> Is there a particular reason two copies of
>>> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
>>>
>>> 1. MdePkg
>>> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> 2. StandaloneMmPkg
>>> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> The only substantial difference (apart from copyright and comment
>>> differences) is that the StandaloneMmPkg instance contains a function
>>> declaration for EfiMain().
>>
>> I believe this may have been an omission in commit d6253d2f9a33
>> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
>> driver", 2019-03-11).
>>
>> At that point, both the library class & instance had been migrated to
>> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>>
>> Can you propose a patch (unless I'm wrong, of course)?
>>
> 
> I think you are correct.
> 
> For a patch that deletes
> 
> StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> and any stale references to it that may exist:
> 
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> 
> 
> 
>