From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.4222.1614153128936943049
 for <devel@edk2.groups.io>;
 Tue, 23 Feb 2021 23:52:09 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OzW/MxQG;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E8AC864EF5
	for <devel@edk2.groups.io>; Wed, 24 Feb 2021 07:52:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1614153128;
	bh=Owz0wVVC0rB1muMahezpNmeqth+Qeu7DBzHex/jj44o=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=OzW/MxQG/FoQytx1V5H0S4ES/oaFTHrOJHY0eYBg3j7cizXVW7PnZx5Bfbisn1d7n
	 EGROKy7Udqy5gSXLZFazNqxZCAbt+gyCK+9+VaS/JLDgygcD98gAMdeZHbqPvZCxKq
	 m32jqK3ZdWSFAh+uczt6ysw6S/MZoXqU+s1G+XS9uP8uoxjcpK3swilP0K8wFl2Le6
	 Cd0TRKS3gc6Z0P3LQp5iZRGbrj3RAS4TfkkgfzULkCDUEdNwyUagQ3KWkSDIXa6/Hh
	 6y04erFcw35xTU1C8XY6gq7vUrDpLPIGD+Si2RoJII3LagfDGhsP3Wv1VljGETA6Bh
	 DX1nbFhKJLTmw==
Received: by mail-ot1-f54.google.com with SMTP id f33so1321778otf.11
        for <devel@edk2.groups.io>; Tue, 23 Feb 2021 23:52:07 -0800 (PST)
X-Gm-Message-State: AOAM532lfICZf3ueUkWGzlB6YdEMYkI4Bx6OzPJ5JxiQsAnyEzI5j16h
	orYmIBKpT0VzkNc39/54YcMyafPFDyRNVS+Dhjc=
X-Google-Smtp-Source: ABdhPJzwtnBnCKQDIF9K5Hbj4VLD8InYtgxMg4fgGiF+Wk8tIvPk8GaqKlOr4ZYRiLILOUGJKFFvDH6E//qoOFo6qfQ=
X-Received: by 2002:a9d:7512:: with SMTP id r18mr1060623otk.90.1614153127096;
 Tue, 23 Feb 2021 23:52:07 -0800 (PST)
MIME-Version: 1.0
References: <b59eebc8-beb8-9e0e-e0d3-6bc07aa77276@linux.microsoft.com> <a6991160-035c-6726-79ad-34e7b272fefc@redhat.com>
In-Reply-To: <a6991160-035c-6726-79ad-34e7b272fefc@redhat.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 24 Feb 2021 08:51:56 +0100
X-Gmail-Original-Message-ID: <CAMj1kXGqADJCwqw5T42+sGdd6+M826jZNiUuPCg1w7Q1C+T6Xg@mail.gmail.com>
Message-ID: <CAMj1kXGqADJCwqw5T42+sGdd6+M826jZNiUuPCg1w7Q1C+T6Xg@mail.gmail.com>
Subject: Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, Michael Kubacki <mikuback@linux.microsoft.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Supreeth Venkatesh <supreeth.venkatesh@arm.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Hi Michael,
>
> On 02/22/21 23:11, Michael Kubacki wrote:
> > Is there a particular reason two copies of
> > StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> >
> > 1. MdePkg
> > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > 2. StandaloneMmPkg
> > https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > The only substantial difference (apart from copyright and comment
> > differences) is that the StandaloneMmPkg instance contains a function
> > declaration for EfiMain().
>
> I believe this may have been an omission in commit d6253d2f9a33
> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
> driver", 2019-03-11).
>
> At that point, both the library class & instance had been migrated to
> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>
> Can you propose a patch (unless I'm wrong, of course)?
>

I think you are correct.

For a patch that deletes

StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h

and any stale references to it that may exist:

Acked-by: Ard Biesheuvel <ardb@kernel.org>